Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No 'state' included with issue/PR comments #94

Closed
dgw opened this issue Jul 27, 2021 · 0 comments · Fixed by #95
Closed

No 'state' included with issue/PR comments #94

dgw opened this issue Jul 27, 2021 · 0 comments · Fixed by #95
Labels
bug
Milestone
0.4.3

Comments

@dgw
Copy link
Member

dgw commented Jul 27, 2021

Looks like #87 broke fetching comments because there won't be a state key in the returned JSON.

If it's important to know whether the issue/PR commented upon is open or closed, this will always require two API calls to display comments. If not important, that part of the logic can just be skipped for comment display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

github: don't try to access issue state in comment payloads sopel-irc/sopel-github
1 participant
@dgw