Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameScope: Add chckbox for ENABLE_GAMESCOPE_WSI environment variable #895

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Sep 5, 2023

This can be used by DXVK v2.3 for some Vulkan optimisations when disabling vsync, as well as some HDR options within GameScope it looks like.

This still needs testing.

TODO:

  • Test this change (i.e. make sure it doesn't break any existing GameScope stuff, can't actually test the functionality)
  • Update langfiles

This can be used by DXVK v2.3 for some Vulkan optimisations when disabling vsync, as well as some HDR options within GameScope it looks like.
@sonic2kk sonic2kk marked this pull request as draft September 5, 2023 20:08
@sonic2kk sonic2kk marked this pull request as ready for review September 5, 2023 20:18
@sonic2kk
Copy link
Owner Author

sonic2kk commented Sep 5, 2023

Tested and the option works, doesn't seem to cause regressions when toggling other options or other STL Game Menu options (as those impact game config, global conf should be entirely unaffected).

Did not test if this breaks any games yet. Once this is confirmed to be safe, I will merge.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Sep 5, 2023

Pending a version bump, this change looks good to go. Tested with DOOM 3, GameScope appeared to work as expected and the option did not break anything (though I was not using DXVK v2.3). Seems to work as expected, at least with the option simply being an environment variable toggle before GameScope launch.

@sonic2kk sonic2kk merged commit 15271f6 into master Sep 5, 2023
@sonic2kk sonic2kk deleted the gamescope-wsi-enable branch September 10, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant