Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langfiles: Update Steam Deck Compatibility localisation strings #887

Merged
merged 16 commits into from
Aug 27, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Aug 27, 2023

This PR is a work-in-progress that will update the language file strings for the other languages that SteamTinkerLaunch supports, to improve localisation.

These strings are taken from SteamDatabase's extracted localization data from the Steam Client. To make the process a bit less painful, I created a Python string that can take the input strings copypasted from the shared_langname.json file on the SteamDatabase repo, and convert them into the language string format that SteamTinkerLaunch expects.

with open('strings.txt') as instrings:
    for s in instrings:
        keyval_split = s.split(':')
        
        string_key = keyval_split[0].strip()
        string_val = keyval_split[1].strip()[:-1]
        
        formatted_string_key = string_key.replace('"', '').upper()
        
        print(f'{formatted_string_key}={string_val}')

This will be used to put the data for other languages that SteamTinkerLaunch supports into their respective language files.

TODO:

  • Other languages
  • Ensure all strings end with full stops
  • Check that all langfile syntax is fine and not broken

@sonic2kk sonic2kk force-pushed the steamdeck-compatibility-langfiles-multilang branch from 095094a to c79b612 Compare August 27, 2023 04:19
@sonic2kk
Copy link
Owner Author

It turns out having a full stop at the end of Steam strings is inconsistent between languages and even some strings in the same file are missing them, so there are inconsistencies there too.

For consistency here, I will manually check the Steam Deck Compatibility strings to ensure they all end in a full stop before merging.

@sonic2kk
Copy link
Owner Author

Chinese will be left out of this PR because I am not sure which of the Steam Chinese files to use. The language strings for Chinese are mostly up-to-date anyway thanks to the efforts of community contributors, so for the most part the strings are translated already except for the new ones in #887.

@sonic2kk sonic2kk force-pushed the steamdeck-compatibility-langfiles-multilang branch from 301249b to 3bc411a Compare August 27, 2023 04:41
@sonic2kk sonic2kk force-pushed the steamdeck-compatibility-langfiles-multilang branch from fbd3e37 to 47e5dc0 Compare August 27, 2023 04:50
@sonic2kk
Copy link
Owner Author

Punctuation should be consistent now, and fixed up a couple of issues where the updated strings were not ended properly.

Things should be ready for this PR now.

@sonic2kk sonic2kk merged commit 72ad1b3 into master Aug 27, 2023
@sonic2kk sonic2kk deleted the steamdeck-compatibility-langfiles-multilang branch August 27, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant