-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One-Time Run: Allow Steam Linux Runtime #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No frontend options yet, and this was written at 1am, so it should be re-checked.
Also includes some shellcheck fixes.
Options same to all be saving correctly except for the Proton version, odd... |
Fixed the saving issue. |
It gets cut off on my KDE machine but it's fine
Notifier added. Langfiles and wiki need updated now. |
Langfiles updated, this should be ready to merge |
Did one final round of testing (using Committee of Zero STEINS;GATE patch installer) and everything works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work for #788.
Overview
Using the Steam Linux Runtime can improve compatibility with executables, particularly on Steam Deck with builds of Proton 8 and above. Though this is not always the case.
In spite of this, Proton is intended to be used with the Steam Linux Runtime (though not fully intended to be used outside of Steam in general). Giving users the option to use the SLR is consistent with how Proton is supposed to be used, and allows users to toggle it based on their needs.
I have yet to see an instance personally where this is required for One-Time Run, but I have yet to run into a case where I required the Steam Linux Runtime on my PC. This option may be useful on Steam Deck for One-Time Run where applications may fail.
Implementation
We fetch the SLR to use using Pressure Vessel Funtime in
setSLRReap
, called fromsetNonGameSLRReap
. We tellsetNonGameSLRReap
whether to get the native or Proton SLR based onISWINDOWSEXE
.The SLR can be enabled from the GUI by checking the "Use Steam Linux Runtime" option. On the command line, it can be toggled with the
--useslr
flag. STL can then infer what SLR it needs to get. Example usage:TODO
--useslr
option