Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Move GLOBCUSTVARS in to EDITORCFGLIST section to show in EDITOR menu #1159

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

HanPrower
Copy link
Contributor

A simple change which allows global-custom-vars.conf to show up in the EDITOR dialog.

@sonic2kk
Copy link
Owner

Huh, I never used that dog, but change makes sense to me.

Tested and it appears as expected with this PR.

image

I guess the per-game environment variables path already shows up here (I believe it's gamecfgs/customvars/<appid>.conf), so the global variables were likely just missed.

Not that it invalidates these changes as all, but the global custom variables file is also available under the "Game Files" menu as well.


Looks good, I think this can be merged as-is. Thanks! :-)

@sonic2kk sonic2kk changed the title Move GLOBCUSTVARS in to EDITORCFGLIST section to show in EDITOR Editor: Move GLOBCUSTVARS in to EDITORCFGLIST section to show in EDITOR menu Aug 31, 2024
@sonic2kk sonic2kk merged commit 49743db into sonic2kk:master Aug 31, 2024
1 check passed
@HanPrower HanPrower deleted the editor-global-customvars branch September 1, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants