-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steam Linux Runtime: Re-enable parsing Steam Linux Runtime from Compatibility Tool start command #1086
Conversation
…tibility Tool start command Primarily (but not exclusively) allows native games that have a Steam Linux Runtime selected (either by the user, or by Valve as sometimes they force SLR 1.0 or 3.0 for games) to launch with the SLR selected. Previously, the SLR would be ignored entirely if it came from the compatibility tool, but this causes incompatibilities with games that REQUIRE a specific SLR version (ex: CS2 requires SLR 3.0 and is selected by Valve, the user doesn't have a choice) This change allows STL to read the SLR coming from the compat tool launch, so if a game is launched with a specified SLR version, we will use this instead of ignoring or building the start command ourselves.
Copied from #1084 (comment) Tested and the following scenarios work:
This PR is ready to merge pending feedback from OP of original issue. In my testing this works as expected and fixes the issue, without causing regressions, and actually adds the benefit of STL being able to pick up the SLR for native games if enforced by the user, which can be handy! This means users that manually enable SLR 3.0 can use it too (STL cannot yet allow SLR 3.0 for native titles). |
In future, we should have a dropdown to select the Native Linux Steam Linux Runtime, and let the user decide to use 1.0 or 3.0. We should make it clear that this is for native titles only. This value can override |
Confirmed to fix the issue by OP, this needs a little bit of comment cleanup, version bump, and it's good to merge. |
Fixes #1084
Primarily (but not exclusively) allows native games that have a Steam Linux Runtime selected (either by the user, or by Valve as sometimes they force SLR 1.0 or 3.0 for games) to launch with the SLR selected.
Previously, the SLR would be ignored entirely if it came from the compatibility tool, but this causes incompatibilities with games that REQUIRE a specific SLR version (ex: CS2 requires SLR 3.0 and is selected by Valve, the user doesn't have a choice)
This change allows STL to read the SLR coming from the compat tool launch, so if a game is launched with a specified SLR version, we will use this instead of ignoring or building the start command ourselves.
TODO: