-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lutris and GE wine builds #660
Comments
Thanks :-) I said it on the other issue too but for completeness, I am fully in favour of adding these features. Sadly I just don't have time to work on it right now, but in future I am hoping to! It may not make it into v12 though |
Something to note here is that some parts of SteamTinkerLaunch including Steam expect a specific directory structure including a Proton script, which afaik the GE-Wine and Lutris Wine builds do not have (since they are Wine builds). I also suspect they have slightly different directory structures, including GE-Wine which may have a different structure to GE-Proton. I think the "solution" here is to do two things:
The merit in having support for the Wine builds is mainly for custom commands, or at least that's how i see it. I think it would be handy to be able to run a custom command with a GE-Wine build for example. And also, in general, the ability to download these tools would be handy too. A potential implementation would be to allow downloading these versions, writing them out to a separate CSV file and then showing them in a separate dropdown under "Wine Options". This would override the system Wine and of course the regular Proton version. I also like this approach because it means Wine options won't be listed under "Proton version". This will unfortunately almost certainly miss v12, but it is something I would like to see added at some point! |
I think having a separate CSV for these tools is the best solution, and having it as a separate menu option gated behind a checkbox perhaps. I'm not sure where it would go, somewhere separate from the Proton options. Maybe if possible this should only be shown if the user has downloaded any custom Wine builds, like how we only show MO2 options for users who have MO2 installed. May look into this soon-ish |
Actually, it should be possible to just integrate this with the existing Wine download options...
|
Ok, I implemented it for Wine-GE and Lutris Wine. PR will be up shortly. Game compatibility may vary, and the SLR is in use by default - not sure if this is a good idea, but it can be disabled by unchecking the SLR option. A better UI is probably overdue for this Wine downloading. ProtonUp-Qt should let you download the Wine versions and you could move/set a custom install directory, so I am not too worried for now :-) |
I actually decided to just merge this as it shouldn't break any existing code for Wine, and appears to work. Wine versions download and extract correctly, though compatibility compared to regular Proton may vary. It's probably best to only use this with Non-Steam Games/custom commands. Let me know if you run into any issues, and feel free to close if this is resolved now :-) |
sorry it took me a while but finally got around to testing and works for me 👍 |
No worries, it took me much longer to investigate implementing it (turns out 95% of the groundwork was already there 😅) |
System Information
Feature Description
lutris and GE wine builds could be useful
The text was updated successfully, but these errors were encountered: