Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new source for shaders (and addons if support for managing them is added) #1182

Open
zany130 opened this issue Oct 2, 2024 · 2 comments
Open
Labels
enhancement New feature or request help wanted Features/Bug Fixes that welcome contributions ReShade Issues related to using ReShade with SteamTinkerLaunch

Comments

@zany130
Copy link
Collaborator

zany130 commented Oct 2, 2024

System Information

  • SteamTinkerLaunch version: steamtinkerlaunch-v14.0.20240904-1
  • Distribution: Bazzite 40

Feature Description

there is a more up-to-date list of reshade shader repositories at https://github.com/crosire/reshade-shaders/tree/list

There is even a list of reshade add-ons there (if we ever add support for that. I am considering matching the official installer functionality, which allows you to download shaders/addons, but the actual reshade_addon version you need to download yourself (as that will trip anticheat)). I think this is what the Reshade Windows installer uses

@zany130 zany130 added the enhancement New feature or request label Oct 2, 2024
@sonic2kk
Copy link
Owner

sonic2kk commented Oct 2, 2024

I'm not sure how any of our current Shader Repo stuff is implemented but I'm open to an improvement here. I don't use (and quite dislike) ReShade so I don't think I will implement this, but I'm open to it being implemented so long as whoever implements it confirms that it works on their end (I am fine with changes in behaviour if they are an improvement, so long as someone implementing it is familiar with a desired flow 😄)

Since that looks like a regular markdown wiki page we could probably just wget and parse that to get the shader links, and store them in whatever format we currently do.

I'm not sure of the specifics of the current implementation, the most I have ever done is make sure the DLLs go into the right folder with the right name and I have not touched the shader repo stuff for a very long time (2+ years at this point and it was probably by accident the last time). But so long as an implementation is submitted with good testing instructions and that doesn't break whatever is currently in place, I have no objections to this being added. It just won't come from me ;-)

@sonic2kk sonic2kk added the help wanted Features/Bug Fixes that welcome contributions label Oct 2, 2024
@zany130
Copy link
Collaborator Author

zany130 commented Oct 2, 2024

yeah no worries. I just wanted to make an issue for it so I don't forget. I hoping that is would be as straight foward as changing the URL for the reshade repo list. I think the URL can already be changed by the user in the URL page of steamtinkerlaunch so ill just start with testing there .(forgot what it was called but I remember there being a page where you can change the URL of several dependices of STL)

The addon part would be a little more complex and would probably be another PR I do latter down the road (prob not anytime soon)

I not even really sure we should have a downloader for addons but since the official installer does I was thinking we should match it.


for some context since you probably don't use reshade much 😆

Addons are extra .dll that end in .addon that you can add the game directory and they add extra functionality to reshade. And they need the addon version of reshade which allows reshade to work on networked games (by default reshade disables itself if it detects a network connection in the game)

the main one being https://github.com/4lex4nder/ReshadeEffectShaderToggler for controlling the rendering order of shaders

@sonic2kk sonic2kk added the ReShade Issues related to using ReShade with SteamTinkerLaunch label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Features/Bug Fixes that welcome contributions ReShade Issues related to using ReShade with SteamTinkerLaunch
Projects
None yet
Development

No branches or pull requests

2 participants