Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811][show] Add bgpraw to show run all #2603

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Jan 17, 2023

What I did

Backport #2537
Add bgpraw output to show runningconfiguration all

How I did it

Generate bgpraw output then append it to show runnningconfiguration all's output

How to verify it

There is not unit test support on such old version.
Manually test on 201811 image.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@wen587 wen587 requested a review from yxieca January 17, 2023 07:36
@wen587 wen587 marked this pull request as ready for review January 17, 2023 07:37
@qiluo-msft
Copy link
Contributor

The testcase is missing. Could you backport?

@wen587 wen587 requested a review from qiluo-msft February 14, 2023 04:44
@wen587
Copy link
Contributor Author

wen587 commented Feb 16, 2023

The testcase is missing. Could you backport?

201811 doesn't have full support of show test. I manually test on device.
I will see if we can add test from sonic-mgmt side.

Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve PR description before merging.

@wen587 wen587 merged commit e86e275 into sonic-net:201811 Feb 17, 2023
@wen587 wen587 deleted the o_201811 branch February 17, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants