Convert IPv6 addresses to lowercase in apply-patch #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dbarashinvd
force-pushed
the
dbarashi_master_ipv6address
branch
from
81c3c3a to
b22d410
Compare
|
@isabelmsft Please help review this PR. |
isabelmsft
reviewed
Aug 9, 2022
squash! convert IPv6 addresses to lowercase in apply-patch
dbarashinvd
force-pushed
the
dbarashi_master_ipv6address
branch
from
b22d410 to
8f7e4ff
Compare
|
@isabelmsft - comment was addressed. Can you please approve ? |
isabelmsft
approved these changes
Aug 10, 2022
liat-grozovik
approved these changes
Aug 11, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 11, 2022
Update sonic-utilities submodule pointer to include the following: * Convert IPv6 addresses to lowercase in apply-patch ([sonic-net#2299](sonic-net/sonic-utilities#2299)) * [CLI] Move hostname, mgmt interface/vrf config to hostcfgd ([sonic-net#2173](sonic-net/sonic-utilities#2173)) * [config][muxcable] add support to enable/disable ycable telemetry ([sonic-net#2297](sonic-net/sonic-utilities#2297)) Signed-off-by: dprital <[email protected]>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 11, 2022
Fixes sonic-net/sonic-buildimage#11622 - What I did Convert IPv6 addresses to lowercase in apply-patch for remove op - How I did it python regex on 'remove' op in JSON patch input file - How to verify it Manual test of created bug, Unit test
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 11, 2022
Update sonic-utilities submodule pointer to include the following: * Convert IPv6 addresses to lowercase in apply-patch ([#2299](sonic-net/sonic-utilities#2299)) * [CLI] Move hostname, mgmt interface/vrf config to hostcfgd ([#2173](sonic-net/sonic-utilities#2173)) * [config][muxcable] add support to enable/disable ycable telemetry ([#2297](sonic-net/sonic-utilities#2297)) Signed-off-by: dprital <[email protected]>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 12, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test failure in dump table test in 202205 ([sonic-net#2307](sonic-net/sonic-utilities#2307)) * Convert IPv6 addresses to lowercase in apply-patch ([sonic-net#2299](sonic-net/sonic-utilities#2299)) * [config][muxcable] add support to enable/disable ycable telemetry ([sonic-net#2297](sonic-net/sonic-utilities#2297)) * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * Support to enable fips for the command sonic_installer (sonic-net#2154) ([sonic-net#2303](sonic-net/sonic-utilities#2303)) Signed-off-by: dprital <[email protected]>
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
Fixes sonic-net/sonic-buildimage#11622 - What I did Convert IPv6 addresses to lowercase in apply-patch for remove op - How I did it python regex on 'remove' op in JSON patch input file - How to verify it Manual test of created bug, Unit test
|
@dbarashinvd In the initial config, the INTERFACE's IPv6 was all loaded in uppercase. GCU will never be able to remove that IP because IPv6 was always translated to lowercase due to this PR. It reported error This PR is to deal with this issue: sonic-net/sonic-buildimage#11622. Although config CLI always translates uppercase to lowercase when adding an IP, user can have two choices to remove that IP: One is to use config CLI to remove that IP no matter uppercase or lowercase. Another way is to use GCU. In order to use GCU, the user has to check the IP format saved in ConfigDB because GCU operation does differentiate between uppercase and lowercase. |
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 28, 2023
…2758) This reverts commit 28b6ba5. There are some issues when GCU tries to remove the interface IP in some tests, such as add rack test. In the initial config, the INTERFACE's IPv6 was all loaded in uppercase by default. "INTERFACE": { "Ethernet68": {}, "Ethernet68|10.0.0.34/31": {}, "Ethernet68|FC00::45/126": {}, "Ethernet72": {}, "Ethernet72|10.0.0.36/31": {}, "Ethernet72|FC00::49/126": {}, GCU will never be able to remove that IP because IPv6 was always translated to lowercase due to #2299 . It reported the error can't remove a non-existent object, thus making GCU fail. #2299 is to deal with this issue: sonic-net/sonic-buildimage#11622. Although config CLI always translates uppercase to lowercase when adding an IP, the user can have two choices to remove that IP: One is to use config CLI to remove that IP no matter uppercase or lowercase. Another way is to use GCU. In order to use GCU, the user has to check the IP format saved in ConfigDB because GCU operation does differentiate between uppercase and lowercase. #### What I did Revert #2299
yxieca
pushed a commit
that referenced
this pull request
Apr 1, 2023
…2758) This reverts commit 28b6ba5. There are some issues when GCU tries to remove the interface IP in some tests, such as add rack test. In the initial config, the INTERFACE's IPv6 was all loaded in uppercase by default. "INTERFACE": { "Ethernet68": {}, "Ethernet68|10.0.0.34/31": {}, "Ethernet68|FC00::45/126": {}, "Ethernet72": {}, "Ethernet72|10.0.0.36/31": {}, "Ethernet72|FC00::49/126": {}, GCU will never be able to remove that IP because IPv6 was always translated to lowercase due to #2299 . It reported the error can't remove a non-existent object, thus making GCU fail. #2299 is to deal with this issue: sonic-net/sonic-buildimage#11622. Although config CLI always translates uppercase to lowercase when adding an IP, the user can have two choices to remove that IP: One is to use config CLI to remove that IP no matter uppercase or lowercase. Another way is to use GCU. In order to use GCU, the user has to check the IP format saved in ConfigDB because GCU operation does differentiate between uppercase and lowercase. #### What I did Revert #2299
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 8, 2023
…2758) This reverts commit 28b6ba5. There are some issues when GCU tries to remove the interface IP in some tests, such as add rack test. In the initial config, the INTERFACE's IPv6 was all loaded in uppercase by default. "INTERFACE": { "Ethernet68": {}, "Ethernet68|10.0.0.34/31": {}, "Ethernet68|FC00::45/126": {}, "Ethernet72": {}, "Ethernet72|10.0.0.36/31": {}, "Ethernet72|FC00::49/126": {}, GCU will never be able to remove that IP because IPv6 was always translated to lowercase due to #2299 . It reported the error can't remove a non-existent object, thus making GCU fail. #2299 is to deal with this issue: sonic-net/sonic-buildimage#11622. Although config CLI always translates uppercase to lowercase when adding an IP, the user can have two choices to remove that IP: One is to use config CLI to remove that IP no matter uppercase or lowercase. Another way is to use GCU. In order to use GCU, the user has to check the IP format saved in ConfigDB because GCU operation does differentiate between uppercase and lowercase. #### What I did Revert #2299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sonic-net/sonic-buildimage#11622
What I did
Convert IPv6 addresses to lowercase in apply-patch for remove op
How I did it
python regex on 'remove' op in JSON patch input file
How to verify it
manual test of created bug
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)