-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202012] [techsupport] Techsupport Error Reporting pending fixes #1854
Conversation
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
This reverts commit 86919fa.
This reverts commit c8b913e.
…o ts_error_handle_202012
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make matching sonic-mgmt test_techsupport_commands() change.
Again, have you tested your change with the test mentioned above?
Signed-off-by: Vivek Reddy Karri <[email protected]>
Raised the changes to sonic-mgmt sonic-net/sonic-mgmt#4504 |
@qiluo-msft could you please help to merge? |
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net#1854) 2569ad9 Fix sFlow sampling-rate and admin-state (sonic-net#1728) 8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848) b42c2fb [VS Test] Skip flaky tests (sonic-net#1875) Signed-off-by: bingwang <[email protected]>
Submodule update for sonic-utilties ``` 48035d7 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854) 8b2ec09 Fix log_ssd_health hang issue (sonic-net#1904) ac9c425 Fix the option missing in kernel config issue (sonic-net#1888) 5cc9417 disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747) ```
What I did
This PR include some fixes which were missed while manually porting the error reporting PR onto 202012 #1833.
i.e. removing -it option from the docker exec commands. to understand why the -it option was removed, refer #1723
This also include another fix which removes -d from the show ip interface command, which fails otherwise.
Note: -d option for "show ip interface" is working on master and 202106. and not for 202012. So, this change is particular to 202012.
Master:
202012:
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)