Fixed coverage issues

sonic_installer/bootloader/grub.py

@@ -154,6 +154,7 @@ def verify_image_platform(self, image_path):
         return self.platform_in_platforms_asic(platform, image_path)
 
     def verify_image_sign(self, image_path):
+        click.echo('Verifying image signature')
         verification_script_name = 'verify_image_sign.sh'
         script_path = os.path.join('/usr', 'local', 'bin', verification_script_name)
         if not os.path.exists(script_path):

tests/installer_bootloader_grub_test.py

@@ -53,3 +53,11 @@ def test_set_fips_grub():
 
     # Cleanup the _tmp_host folder
     shutil.rmtree(tmp_host_path)
+
+def test_verify_image():
+
+    bootloader = grub.GrubBootloader()
+    image = f'{grub.IMAGE_PREFIX}expeliarmus-{grub.IMAGE_PREFIX}abcde'
+
+    # command should fail
+    assert not bootloader.verify_image_sign(image)

tests/test_sonic_installer.py

@@ -3,6 +3,7 @@
 from sonic_installer.main import sonic_installer
 from click.testing import CliRunner
 from unittest.mock import patch, Mock, call
+from sonic_installer.bootloader import GrubBootloader
 
 @patch("sonic_installer.main.SWAPAllocator")
 @patch("sonic_installer.main.get_bootloader")
@@ -32,7 +33,6 @@ def test_install(run_command, run_command_or_raise, get_bootloader, swap, fs):
     mock_bootloader.get_installed_images = Mock(return_value=[current_image_version])
     mock_bootloader.get_image_path = Mock(return_value=new_image_folder)
     mock_bootloader.verify_image_sign = Mock(return_value=True)
-
     @contextmanager
     def rootfs_path_mock(path):
         yield mounted_image_folder
@@ -46,7 +46,13 @@ def rootfs_path_mock(path):
     print(result.output)
 
     assert result.exit_code == 0
+    mock_bootloader_verify_image_sign_fail = mock_bootloader
+    mock_bootloader_verify_image_sign_fail.verify_image_sign = Mock(return_value=False)
+    get_bootloader.return_value=mock_bootloader_verify_image_sign_fail
+    result = runner.invoke(sonic_installer.commands["install"], [sonic_image_filename, "-y"])
+    print(result.output)
 
+    assert result.exit_code != 0
     # Assert bootloader install API was called
     mock_bootloader.install_image.assert_called_with(f"./{sonic_image_filename}")
     # Assert all below commands were called, so we ensure that