Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LOGLEVEL DB since is no longer used #2507

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

EdenGri
Copy link
Contributor

@EdenGri EdenGri commented Nov 9, 2022

This PR is part of the following HLD:
Persistent loglevel HLD: sonic-net/SONiC#1041

- What I did
Deleted the LOGLEVEL_DB.
After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use.

- How I did it
Removed the LOGLEVEL_DB from the SONiC code

- How to verify it
All tests were passed

Details if related
Persistent loglevel HLD: sonic-net/SONiC#1041

@EdenGri EdenGri requested a review from prsunny as a code owner November 9, 2022 16:15
@EdenGri EdenGri changed the title Remove loglevel db master Remove LOGLEVEL DB since is no longer used Nov 9, 2022
@prsunny prsunny requested a review from yxieca November 9, 2022 21:06
@yxieca
Copy link
Contributor

yxieca commented Nov 9, 2022

@EdenGri Will warm reboot cause this take to come back? Will there be issue if this table show up after upgrading from an older version?

@EdenGri
Copy link
Contributor Author

EdenGri commented Nov 13, 2022

@yxieca Did you mean warm upgrade? In warm upgrade, the content from the LOGLEVEL_DB moves to the CONFIG_DB. There is nothing in the LOGLEVEL_DB after the warm-reboot.

@liat-grozovik liat-grozovik merged commit da56bd6 into sonic-net:master Nov 14, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Nov 14, 2022
Update sonic-swss submodule pointer to include the following:
* da56bd6 Remove LOGLEVEL DB since is no longer used ([sonic-net#2507](sonic-net/sonic-swss#2507))

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants