Fix vs test issue: failed to remove vlan due to referenced by vlan interface #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface Fix: remove vlan interface before removing the vlan itself Signed-off-by: Stephen Sun <[email protected]>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @prsunny |
prsunny
approved these changes
Nov 2, 2022
7 tasks
|
@prsunny @stephenxs @yxieca Added |
yxieca
pushed a commit
that referenced
this pull request
Nov 29, 2022
…terface (#2504) *Fix: remove vlan interface before removing the vlan itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix: remove the VLAN interface before removing the VLAN itself
Signed-off-by: Stephen Sun [email protected]
Why I did it
There is a logic in VLAN vs test cases
test_VlanGratArpandtest_VlanProxyArpto create a VLAN, a VLAN interface and then remove the VLAN and then check whether the VLAN is removed from SAI.However, the step to remove the VLAN interface is missed, which causes the VLAN to be referenced and prevents it from being deleted.
How I verified it
Run vs test.
Details if related