Use abort instead of exit in case calling SAI API failure #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
prsunny
approved these changes
Mar 8, 2022
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
it can be cherry-picked to 202111 smoothly (tested on b3e5e33) |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
judyjoseph
pushed a commit
that referenced
this pull request
Mar 20, 2022
- What I did
Use abort instead of exit in case calling SAI API failure
Currently, exit is used in functions handleSai{Create,Remove,Set,Get}Status on SAI failure while abort is used in some other functions on SAI failure.
IMO using abort yields benefits:
Consistent behavior in orchagent on SAI failure in mocked test, in case SAI failure occurs the test process will just exit silently, which makes it very difficult for developers to find out what happened. by using abort, a coredump will be generated, which helps developers nail down the issue.
So we would like to use abort in all cases of receiving SAI failure.
- Why I did it
- How I verified it
Manually test.
Signed-off-by: Stephen Sun <[email protected]>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…2170) - What I did Use abort instead of exit in case calling SAI API failure Currently, exit is used in functions handleSai{Create,Remove,Set,Get}Status on SAI failure while abort is used in some other functions on SAI failure. IMO using abort yields benefits: Consistent behavior in orchagent on SAI failure in mocked test, in case SAI failure occurs the test process will just exit silently, which makes it very difficult for developers to find out what happened. by using abort, a coredump will be generated, which helps developers nail down the issue. So we would like to use abort in all cases of receiving SAI failure. - Why I did it - How I verified it Manually test. Signed-off-by: Stephen Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Use
abortinstead ofexitin case calling SAI API failureCurrently,
exitis used in functionshandleSai{Create,Remove,Set,Get}Statuson SAI failure whileabortis used in some other functions on SAI failure.IMO using
abortyields benefits:abort, a coredump will be generated, which helps developers nail down the issue.So we would like to use
abortin all cases of receiving SAI failure.Signed-off-by: Stephen Sun [email protected]
Why I did it
How I verified it
Manually test.
Details if related