Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compilation error because github.com/go-redis/redis moved to v-8 #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdosi
Copy link

@abdosi abdosi commented May 21, 2020

What I did

Fix the compilation error because github.com/go-redis/redis moved
to v8 branch which made the ctx argument mandatory for the API's
that are failing compilation error.
To fix this passing context.TODO() based on reference redis/commands_test.go

How I verify

verified Compilation is fine after this change.

got merge v8 branch which made this argument mandatory for the API's
that are failing.
To fix this passing context.TODO() based on refernece
redis/commands_test.go
Copy link
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I would suggest to pin the version of the library.
Otherwise it will break our code all the time.
Especially if you want to build some old branch.

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sumukhatv
Copy link
Collaborator

v8 is a beta version: https://pkg.go.dev/github.com/go-redis/redis/v8?tab=doc
Not sure we want to consume it.

@jarias-lfx
Copy link

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants