Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build process is trying to pull ipmitool version no longer available, updategraph.service not generated #117

Closed
Krishnamoney opened this issue Oct 2, 2024 · 17 comments

Comments

@Krishnamoney
Copy link

Trying to build the repository failed with error trying to pull outdated/non existing ipmitool version and requires manual edits to point this to the latest available version for build to complete.
vppcfg service requires updategraph.service which was not present in the vm image.

@yue-fred-gao
Copy link
Contributor

We are in the process to push vpp to sonic-buildimage. Once that is done, we will be able to build sonic-vpp directly from sonic-buildimage, as any other platform.

For vppcfg service, I might have broken it during this activity. Here are some basic questions: what is vppcfg service? How is it used? I can't find any doc about it.

@Krishnamoney
Copy link
Author

Krishnamoney commented Oct 7, 2024

We were trying to bring up the VM image and seems like vpp docker image is started by systemctl service of linux, and this service failed to start (the vppcfg service ) with error since dependent service update graph is not installed/present.

@Krishnamoney
Copy link
Author

Any timelines available for proposed vpp merge push to sonic build image?

@yue-fred-gao
Copy link
Contributor

We were trying to bring up the VM image and seems like vpp docker image is started by systemctl service of linux, and this service failed to start (the vppcfg service ) with error since dependent service update graph is not installed/present.

In which git commit id do you see this? In the VM image, I don't think we need vppcfg service.

@yue-fred-gao
Copy link
Contributor

Any timelines available for proposed vpp merge push to sonic build image?

I think by the end of Oct this should be done. The sonic side of change has been approved.

@Krishnamoney
Copy link
Author

We were trying to bring up the VM image and seems like vpp docker image is started by systemctl service of linux, and this service failed to start (the vppcfg service ) with error since dependent service update graph is not installed/present.

In which git commit id do you see this? In the VM image, I don't think we need vppcfg service.

I was using latest tip of the tree. I thought we might need some systemctl service which brings up vpp container once VM is booted and looking for the services present in the VM.

@linqingxuan
Copy link
Contributor

We were trying to bring up the VM image and seems like vpp docker image is started by systemctl service of linux, and this service failed to start (the vppcfg service ) with error since dependent service update graph is not installed/present.

In which git commit id do you see this? In the VM image, I don't think we need vppcfg service.

I think this initialization interface related project is used to read data from redis to initialize the interface. Later, I think it can be expanded in some ways that are not issued from sai.

@yue-fred-gao
Copy link
Contributor

I have changed interface initialization with PR #106. Interface will be automatically created in the first boot so it behaves the same way as other platforms. There is no need to run sonic_vpp_cfg.sh then reboot to bring up data ports. It might be less flexible than before because it is taking all interfaces except eth0 as data ports. If we do need different port configuration, we may introduce other hwsku.

@Krishnamoney
Copy link
Author

We also need to fix make sonic_vm build failure. ipmitool_1.8.19-4 is no longer available and should be updated to get ipmitool_1.8.19-7 instead (sonic-platform-vpp/build/sonic-buildimage/rules/ipmitool.mk)

get_url_version https://deb.debian.org/debian/pool/main/i/ipmitool/ipmitool_1.8.19-4.dsc failed
dget: curl ipmitool_1.8.19-4.dsc https://deb.debian.org/debian/pool/main/i/ipmitool/ipmitool_1.8.19-4.dsc failed
make[1]: *** [Makefile:9: /sonic/target/debs/bookworm/ipmitool_1.8.19-4_amd64.deb] Error 1
make[1]: Leaving directory '/sonic/src/ipmitool'
[ FAIL LOG END ] [ target/debs/bookworm/ipmitool_1.8.19-4_amd64.deb ]
make: *** [slave.mk:735: target/debs/bookworm/ipmitool_1.8.19-4_amd64.deb] Error 1
make: *** Waiting for unfinished jobs....
[ 01 ] [ target/debs/bookworm/linux-headers-6.1.0-11-2-common_6.1.38-4_all.deb ]

@yue-fred-gao
Copy link
Contributor

This is not from sonic-vpp but upstream sonic. It is because that version of debian package has been removed from the debian.org. You can try adding MIRROR_SNAPSHOT=y to the make command. We could patch it after download sonic but I see it has little value. When vpp is built from sonic-buildimage, this won't be a problem.

@linqingxuan
Copy link
Contributor

This actually needs to be observed. The new code I pulled yesterday also had the same problem, but the upstream sonic has been changed for a month, and we still have problems when we rebuild it.

@yue-fred-gao
Copy link
Contributor

This is because the current sonic-vpp build process is pegged to a certain version of sonic: https://github.com/sonic-net/sonic-platform-vpp/blob/main/sonic-vpp-setup.sh#L30. That's the issue PR #123 is going to fix.

@yue-fred-gao
Copy link
Contributor

@linqingxuan, if you have time, can you please review PR #123? I can't assign you as reviewer but you can still review and add your comments

@linqingxuan
Copy link
Contributor

OK, I will review this PR [#123 ]#123.

@Krishnamoney
Copy link
Author

When will sonic-platform-vpp become a submodule of sonic-buildimage?

@yue-fred-gao
Copy link
Contributor

I am not sure at the moment. The PR has opened for 2 weeks: sonic-net/sonic-buildimage#20841.

@Krishnamoney
Copy link
Author

Sure - since sonic-net/sonic-buildimage#20841 is going to address this issue, I am closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants