[thermalctld][201911] Set led status after updating all other fan status #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
approved these changes
Nov 26, 2020
abdosi
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 4, 2020
…dating all other fan status (#6055) Update submodule pointer for PR sonic-net/sonic-platform-daemons#126
vdahiya12
added a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…m address space within platform api (sonic-net#126) * [sonic_sfp] adding abstract methods for platform api's Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this?
There could be 2 fans in the same drawer and the final fan drawer LED state is determined by all fans status in this drawer. So we have to update fan LED status after updating other fan status.
Similar fix is already in master.
How I did this?
Use a separate loop to update the fan led in database after updating all other fan status.
How I verify this?
Run test cases in test_platform_info.py.