PSUd changes to compute power-budget for Modular chassis #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSUd will introduce power requirements calculations. Platform APIs are introduced to provide consumers and total consumed power. Number of PSUs will help provide total supplied power
Addressed review-comments to move get_maxiumum_consumed_power(), get_status_master_led() and set_status_master_led() to PSU etc. This can in future be added to Fan and other peripherals Added UT to test the power-budget feature
|
@judyjoseph , Shyam, Samuel A( Arista) - please review this PR. Thanks |
Staphylo
reviewed
Oct 28, 2020
judyjoseph
reviewed
Nov 3, 2020
|
@Junchao-Mellanox: Please review, also. |
Junchao-Mellanox
approved these changes
Nov 6, 2020
jleveque
changed the title
judyjoseph
approved these changes
Nov 6, 2020
|
@Staphylo, @minionatwork: Please review again. |
|
Please fix conflicts |
Done. Thanks. |
|
@Staphylo, @minionatwork: Please review again. |
minionatwork
approved these changes
Nov 11, 2020
Staphylo
approved these changes
Nov 11, 2020
jleveque
approved these changes
Nov 11, 2020
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…r_info_dict for platform api 1.0 (sonic-net#104) Fixes the following bug reproduced on SONiC.HEAD.729-dirty-20200727.075328: ``` pmon#supervisord: xcvrd Traceback (most recent call last): INFO pmon#supervisord: xcvrd File "/usr/bin/xcvrd", line 1207, in <module> INFO pmon#supervisord: xcvrd main() INFO pmon#supervisord: xcvrd File "/usr/bin/xcvrd", line 1204, in main INFO pmon#supervisord: xcvrd xcvrd.run() INFO pmon#supervisord: xcvrd File "/usr/bin/xcvrd", line 1165, in run INFO pmon#supervisord: xcvrd self.init() INFO pmon#supervisord: xcvrd File "/usr/bin/xcvrd", line 1144, in init INFO pmon#supervisord: xcvrd post_port_sfp_dom_info_to_db(is_warm_start, self.stop_event) INFO pmon#supervisord: xcvrd File "/usr/bin/xcvrd", line 430, in post_port_sfp_dom_info_to_db INFO pmon#supervisord: xcvrd post_port_sfp_info_to_db(logical_port_name, int_tbl, transceiver_dict, stop_event) INFO pmon#supervisord: xcvrd File "/usr/bin/xcvrd", line 260, in post_port_sfp_info_to_db INFO pmon#supervisord: xcvrd ('application_advertisement',port_info_dict['application_advertisement'])]) INFO pmon#supervisord: xcvrd KeyError: 'application_advertisement' ``` Signed-off-by: Volodymyr Boyko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSUd changes to computer power-budget for Modular chassis
HLD: sonic-net/SONiC#646
PSUd will introduce power requirements calculations. Platform APIs are introduced to provide consumers and total consumed power. Number of PSUs will help provide total supplied power
Output of STATE-DB: