fix: using PAGE_LENGTH instead of INIT_OFFSET #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rqx110 please add more details in the PR Description Motivation and Context Additional Information (Optional) |
prgeor
approved these changes
May 1, 2024
prgeor
approved these changes
May 8, 2024
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…y once (sonic-net#452) The values of position_in_parent and parent_name for PSU will remain unchanged. Consequently, update the predefined position_in_parent and parent_name of the PSU only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sonic-platform-common/sonic_platform_base/sonic_xcvr/api/public/cmisCDB.py
Lines 360 to 367 in 2606cd5
here, on line 363 uses
PAGE_LENGTH, but on line 366 usesINIT_OFFSET. This must be an oversight。Although the two values are equal, they are semantically different.
Motivation and Context
None
Additional Information (Optional)