[tests/copp]: Update copp mgmt tests to support new rate-limits #8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
* Rate limits are being set for bgp, lacp, dhcp, lldp, udld and macsec via a copp cfg change. This is the corresponding sonic-mgmt change Signed-off-by: Prabhat Aravind <[email protected]>
prabhataravind
force-pushed
the
copp_rate_limit
branch
from
496bad1 to
ce9cfe7
Compare
neethajohn
reviewed
Oct 18, 2023
|
Please also state the dependency on the buildimage PR explicitly in the description so that the merge for this one happens after the other PR |
* Updated comments for new rate limiting configurations Signed-off-by: Prabhat Aravind <[email protected]>
Done. Thanks! |
neethajohn
approved these changes
Oct 19, 2023
|
Cherry-pick PR to 202305: #10615 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 2, 2023
…c-net#8199) * [tests/copp]: Update copp mgmt tests to support new rate-limits * Rate limits are being set for bgp, lacp, dhcp, lldp, udld and macsec via a copp cfg change. This is the corresponding sonic-mgmt change
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 2, 2023
* [tests/copp]: Update copp mgmt tests to support new rate-limits * Rate limits are being set for bgp, lacp, dhcp, lldp, udld and macsec via a copp cfg change. This is the corresponding sonic-mgmt change
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
11 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Rate limits are being set for bgp, lacp, dhcp, lldp, udld and macsec via a copp cfg change via sonic-buildimage PR
image_config: copp: Enable rate limiting for bgp, lacp, dhcp, lldp, macsec and udld sonic-buildimage#14859. This is the corresponding sonic-mgmt change to make sure that copp tests don't fail with the updated rate limits.
This change is dependent on the the sonic-buildimage PR above and will be committed after the buildimage PR is merged.
Summary:
Fixes # 17964421
Type of change
Back port request
Approach
What is the motivation for this PR?
It was observed that a flood of DHCP packets without rate-limiting can cause BGP flaps or lacp keepalive losses.
How did you do it?
Enable rate-limiting for all traffic types to prevent such BGP flaps.
How did you verify/test it?
By injecting DHCP traffic at a fast enough rate and verifying that they are indeed throttled.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation