Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD Echomode testplan.md #11898

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

Ghulam-Bahoo
Copy link
Contributor

Description of PR

This PR provides enhancement in the existing test plan for BFD with echo-mode. The test plan comprises of one test case:

  1. Test case BFD Echo Mode

Type of change

Added a new test plan to run BFD echo-mode along with BGP routing protocol.

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Currently, there is no existing test plan for running BFD echo-mode in SONiC. This test plan helps the user configure BFD echo-mode in the existing testbed and framework.

How did you do it?

This test case uses the existing BGP configurations for routing purpose. BFD neighborship is established between DUT and its neighboring devices. Once BFD neighborship is established then BFD echo-mode is enabled on DUT and its neighboring devices.

How did you verify/test it?

Run the test case on any topology.

Any platform specific information?

It will run on all topologies where neighboring devices are SONiC devices.

Supported testbed topology if it's a new test case?

  • T0 (all variations)
  • T1 (all variations)

Copy link

linux-foundation-easycla bot commented Mar 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/testplan/BFD-echomode-test-plan.md

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@Ghulam-Bahoo Ghulam-Bahoo changed the title BFD-echomode-test-plan.md BFD Echomode testplan.md Mar 6, 2024
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/testplan/BFD-echomode-test-plan.md

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@Ghulam-Bahoo
Copy link
Contributor Author

@yxieca can you please review this PR.

@yxieca yxieca merged commit 10e5688 into sonic-net:master Mar 7, 2024
14 checks passed
@Ghulam-Bahoo Ghulam-Bahoo mentioned this pull request Apr 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants