Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_reload_config issue #11675

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Feb 8, 2024

Description of PR

Fix issue:#11654

  1. Revert PR: Stabilize test_reload_configuration_checks #7289, because the relevant issue has been fixed by PR:Re-add 127.0.0.1/8 when bringing down the interfaces sonic-buildimage#15080
  2. Remove wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: Improvising pre_checks for test_reload config  #7953 due to the above same reason

Summary:
Fixes # (issue)#11654

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Fix issue:#11654

How did you do it?

  1. Revert PR: Stabilize test_reload_configuration_checks #7289, because the relevant issue has been fixed by PR:Re-add 127.0.0.1/8 when bringing down the interfaces sonic-buildimage#15080
  2. Remove wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: Improvising pre_checks for test_reload config  #7953 due to the above same reason

How did you verify/test it?

Run test_reload_config.py

Any platform specific information?

Any

Supported testbed topology if it's a new test case?

Documentation

1. Revert PR: sonic-net#7289, because the relevant issue has been fixed by PR:sonic-net/sonic-buildimage#15080
2. Remove  wait_until(60, 1, 0, check_interfaces_config_service_status, duthost) in PR: sonic-net#7953 due to the above same reason

Change-Id: I022a948cb2e36ba7d5538258159ea047d13d80a7
@liat-grozovik
Copy link
Collaborator

@yxieca could you please help to review or assign someone?

@liat-grozovik
Copy link
Collaborator

@JibinBao on which branches this fix is needed? please update the list if the pr description so we can set the labels accordingly

@yxieca yxieca requested a review from wenyiz2021 February 12, 2024 17:36
@JibinBao JibinBao mentioned this pull request Feb 19, 2024
8 tasks
@JibinBao
Copy link
Contributor Author

@JibinBao on which branches this fix is needed? please update the list if the pr description so we can set the labels accordingly

hi @liat-grozovik , this PR is just for branch 202205, for other branches, I have another PR:#11674

@wangxin wangxin merged commit a6cf129 into sonic-net:202205 Mar 4, 2024
10 checks passed
Copy link
Contributor

@wenyiz2021 wenyiz2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants