[202205] [TACACS] Fix TACACS authorization issue: user can run rejected command when enable local authorization as fallback. #11407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d when enable local authorization as fallback. (sonic-net#11261) What is the motivation for this PR? per-command authorization found a code bug: When set per-command authorization to "tacacs+, local", user command blocked by server side but has local permission should failed. but currently it can success. The UT code changed by this PR is testing and protect this incorrect behavior. How did you do it? Create issue: sonic-net#11349 Fix UT and ignore it temporarily by this issue. How did you verify/test it? Pass all UT
This was referenced Jan 26, 2024
wangxin
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TACACS authorization issue: user can run rejected command when enable local authorization as fallback.
This is a cherry-pick PR for #11261
Description of PR
Fix TACACS authorization issue: user can run rejected command when enable local authorization as fallback.
Work item tracking
Type of change
Back port request
Approach
What is the motivation for this PR?
per-command authorization found a code bug: When set per-command authorization to "tacacs+, local", user command blocked by server side but has local permission should failed. but currently it can success.
The UT code changed by this PR is testing and protect this incorrect behavior.
How did you do it?
Create issue: #11349
Fix UT and ignore it temporarily by this issue.
How did you verify/test it?
Pass all UT
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation