Modify dhcp_relay test case in two vlan scenario to have secondary subnets #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushpraj
approved these changes
Nov 22, 2023
11 tasks
|
@prsunny can you please help to check if you are ok with the test coverage? Thanks. |
|
/Semgrep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Modified the test to suit the secondary subnets scenario, the dhcp related changes are in the PR: sonic-net/sonic-buildimage#17012
Summary:
Fixes # (issue): NA
Type of change
Back port request
Approach
What is the motivation for this PR?
This is to test the changes included in the HLD: sonic-net/SONiC#1470
How did you do it?
Added a new secondary subnets entry in the topology file and added parsing logic for the same
How did you verify/test it?
The existing test cases of dhcp_relay
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
Documentation