Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-telemetry_client.yang and dialout_client.go prefix requirement does not match #280

Open
amareshpGithub opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels

Comments

@amareshpGithub
Copy link

In "https://github.com/sonic-net/sonic-buildimage/tree/master/src/sonic-yang-models/yang-models/sonic-telemetry_client.yang" prefix expect as "Subscription|DestinationGroup"

            leaf prefix {
                type string {
                    pattern 'Subscription|DestinationGroup';
                }
            }

But the in "https://github.com/sonic-net/sonic-gnmi/blob/master/dialout/dialout_client/dialout_client.go", it expect as "DestinationGroup_" and "Subscription_" as mentioned below. Is there any new dialout client?

else if strings.HasPrefix(key, "DestinationGroup_") {
destGroupName := strings.TrimPrefix(key, "DestinationGroup_")
if destGroupName == "" {
return fmt.Errorf("Empty Destination Group name %v", key)
}
// Close any client intances targeting this Destination group

} else if strings.HasPrefix(key, "Subscription_") {
name := strings.TrimPrefix(key, "Subscription_")
if name == "" {
return fmt.Errorf("Empty Subscription_ name %v", key)
}
csub, ok := ClientSubscriptionNameMap[name]
if ok {

@slicking
Copy link

Likely broken by: sonic-net/sonic-buildimage#16861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants