Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rsyslog]: Use timegenerated instead of timestamp #944

Merged
merged 2 commits into from
Sep 9, 2017
Merged

[rsyslog]: Use timegenerated instead of timestamp #944

merged 2 commits into from
Sep 9, 2017

Conversation

marian-pritsak
Copy link
Collaborator

This is useful when rsyslog is used to put markers generated on other machines.
This way all messages will have a timestamp from a single system.

@marian-pritsak
[rsyslog]: Use timegenerated instead of timestamp
23faad3 
This is useful when rsyslog is used to put markers generated on other machines.
This way all messages will have a timestamp from a single system.
@marian-pritsak marian-pritsak self-assigned this Sep 8, 2017
@jleveque
Copy link
Contributor

jleveque commented Sep 8, 2017 •
edited
Loading

As another side effect, it looks like timegenerated always guarantees high-resolution timestamps, whereas timestamp (which is a synonym for timereported) does not.(http://www.rsyslog.com/doc/master/configuration/properties.html),

stcheng
stcheng approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@stcheng stcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one reference: http://www.rsyslog.com/what-is-the-difference-between-timereported-and-timegenerated/

@lguohan lguohan merged commit 8f1ac5d into master Sep 9, 2017
@stcheng stcheng deleted the marian-pritsak-rsyslog branch September 9, 2017 02:33
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Oct 17, 2019
Merge remote-tracking branch 'msft_github/master'
5bf7c5e 
* msft_github/master:
  [snmpagent]: Update sonic-snmpagent submodule (sonic-net#1004)
  [swss]: Update the ipinip.j2 template to specify the IPv4 loopback address (sonic-net#998)
  Change all port_config.ini column headers from 'port' to 'index' (sonic-net#1001)
  [docker-platform-monitor]: Remove stale fancontrol.pid file (if exists) before starting fancontrol (sonic-net#1002)
  [swss]: Update swss/common submodules (sonic-net#988)
  [snmp]: Update py-swsssdk/snmpagent submodules (sonic-net#996)
  [Broadcom]: Update SAI version to 3.0.3.2-5 (sonic-net#997)
  [Mellanox]: Update outdated MSN2410 minigraph (sonic-net#995)
  Add time stamp suffix to the dirty images version string (sonic-net#958)
  [Mellanox]: Remove FW upgrade procedure in docker (sonic-net#989)
  [snmp]: Update sonic-snmpagent submodule (sonic-net#986)
  [Broadcom]: Update SAI version to 3.0.3.2-4 (sonic-net#983)
  [Ingrasys]: Add Ingrasys S8900-64XC sfputil function and update submodule (sonic-net#984)
  [mellanox]: Update Mellanox SAI version (sonic-net#979)
  [Ingrasys]: Change hwmon kernel modules installation order (sonic-net#980)
  [Makefile] Allowing interactive session with the slave docker-container (sonic-net#903)
  [snmp]: Update sonic-snmpagent submodule (sonic-net#978)
  Disable snmpd module disk_hw, so no syslog messages about unavailable disks (sonic-net#977)
  [teamd]: Remove deprecated blocking logic before starting teamd (sonic-net#976)
  [Broadcom]: Update libsai version to 3.0.3.2-2 (sonic-net#973)
  [device/accton]: Add a new supported device, AS7312-54X (sonic-net#955)
  [sairedis]: update sairedis submodule (sonic-net#974)
  lacp runner will send lacp update right after it received SIGINT (sonic-net#969)
  [config]: Fix management interface configuration (sonic-net#966)
  [Broadcom]: Update OpenNSL modules (sonic-net#970)
  [utilities]: Update sonic-utilities (sonic-net#968)
  [interfaces]: Change MTU value to 9100  (sonic-net#967)
  Framework to plugin Organization specific scripts during ONIE Image build  (sonic-net#951)
  Always start with Forwarding State flag set for bgpd (sonic-net#963)
  Update sonic-utilities to be compatible with sonic-net#942 (sonic-net#965)
  [swss]: Fix the command to get HWSKU with sonic-cfggen (sonic-net#964)
  [bgp]: Fix the deployment_id with DEVICE_METADATA (sonic-net#962)
  [Ingrasys] Update Ingrasys submodule for S8900-54XC (sonic-net#954)
  [build/onie installer] Install grub for SONiC post migration from another NOS (sonic-net#949)
  [syncd]: Comment out unused docker-ptf-brcm.mk
  [Broadcom]: Update OpenNSL/SAI version (sonic-net#959)
  [swss]: Move swss/common/sairedis submodule to 201709 tag
  [sairedis]: update sairedis submodule head (sonic-net#956)
  [service template] Starting new docker when HWSKU change is detected (sonic-net#946)
  [config] Fix an issue that bgp asn data type is not consistent (sonic-net#953)
  [mellanox]: Update Mellanox SAI version ansd SDK version
  [Ingrasys] update port_config.ini and sfputil for ingrasys platforms (sonic-net#952)
  [frr]: RR client support in minigraph for FRR (sonic-net#923)
  [configdb] Migrate minigraph configurations to DB (sonic-net#942)
  [devices]: Add led plugin for Arista 7060CX-32S and 7260CX3-64 (sonic-net#945)
  [sonic-slave]: SLAVE_TAG should be for both Dockerfile and Dockerfile.user (sonic-net#950)
  [github]: add templates for submitting issues and PR (sonic-net#947)
  [rsyslog]: Use timegenerated instead of timestamp (sonic-net#944)
  [dell]: remove nos_to_sonic_grub.cfg (sonic-net#943)
  [slave.mk]: Apply series of patches to SONIC_PYTHON_STDEB_DEBS targets if they exist (sonic-net#941)
  [rsyslog]: Use SONiC template in containers (sonic-net#940)
  [Broadcom]: Remove BRCM_OPENNSL library and upgrade BRCM_SAI to 3.0.3.2 (sonic-net#938)
  [baseimage]: allocate varlog disk in the initramfs stage (sonic-net#936)
  [sairedis]: revert deadlock fix in sonic-sairedis submodule (sonic-net#934)
  Replace CRLF line endings with LF (sonic-net#932)
  Fix confusing comment (sonic-net#931)
  Update sfputil support for Ingrasys S9100 (sonic-net#929)
  [quagga]: Disable ipv4 over ipv6 and enable ipv6 over ipv4 peer group (sonic-net#922)
  [quagga] enable core dump for bgpd and zebra (sonic-net#927)
  [devices]: Update Dell s6100/z9100 platform modules (sonic-net#925)
  Revert "Migrate DEVICE_METADATA to db (sonic-net#919)" (sonic-net#928)
  Migrate DEVICE_METADATA to db (sonic-net#919)
  [devices]: Bump sonic-platform-modules-arista submodule (sonic-net#924)
  [image]: build sonic-broadcom.raw image for sonic conversion from ftos (sonic-net#901)
  [sonic-slave] Force pyangbind version to 0.5.10 (sonic-net#918)
  [Arista-7260CX3] Rename hwSKU Arista-7260CX3-64 to Arista-7260CX3-C64, introducing new hwSKU Arista-7260CX3-D108C8 (sonic-net#920)
  [devices]: modify sfputil plugins for mellanox devices for new platform API (sonic-net#916)
  [cavm]Update sai revision and packet driver (sonic-net#914)
  [translate-acl] Specify pyangbind version to not introduce new dependency (sonic-net#915)
  Update sfputil support for Arista platforms (sonic-net#912)
  Port speed (sonic-net#879)
  [Accton]: Add a new supported device AS5712-54X (sonic-net#898)
  [kernel]: update kernel submodule (sonic-net#910)
  [device]: Updated dell s6100 submodule to 5ab014 (sonic-net#909)
  [broadcom]: update broadcom sai package to 2.1.5.1-17 (sonic-net#908)
  IPv4 prefixes shouldn't be sent by default over IPv6 session with FRR. (sonic-net#905)
  [submodule]: update sonic linux kernel (sonic-net#906)
  [sonic-sairedis] update sairedis submodule (sonic-net#211, sonic-net#212) (sonic-net#904)
  [mlnx-fw-upgrade]: Define required FW version in build time. (sonic-net#902)
  [SAI]: Remove the SAI submodule from buildimage repo (sonic-net#893)
  [Submodule update]: sonic-utilities (sonic-net#888)
  Revert "[mellanox]: Update Mellanox SAI version"
  [mellanox]: Update Mellanox SAI version
  [utilities]: Update sonic-utilities submodule
  [swss-common]: Update sonic-swss-common submodule
  [mellanox]: Disable fsat boot mode for SX kernel
  [quagga]: Update sonic-quagga submodule
  [Broadcom]: Update Broadcom SAI/SDK version (sonic-net#883)
  Squash merge v1.0.3 branch onto master
@jleveque jleveque mentioned this pull request Jun 12, 2020
Merged
jleveque added a commit that referenced this pull request Jun 13, 2020
@jleveque
[sonic-utilities] Update submodule (#4770)
0a750a6 
* src/sonic-utilities 5765570...a21e01a (13):
  > [config] Don't attempt to restart disabled services (#944)
  > [crm] Use swsssdk API instead of redis-cli for getting keys from redis DB (#943)
  > Fixed fast-reboot for BFN platform (#871)
  > [sfputil] Add support of platform.json (#767)
  > [show] Add support for SONiC Gearbox Manager via new gearboxutil utility (#931)
  > [warm-reboot]: added pre-check for ISSU file (#915)
  > Add_intf_range (#913)
  > add fec config/show option (#764)
  > Make sure db_migrator is run after all config are loaded during (#926)
  > Changes to make lldp show command for multi-npu platforms. (#914)
  > [showtech]: add knet dump information in show tech (#925)
  > Vnet alias mapping (#924)
  > Revert the change to kdump reboot (#916)
abdosi added a commit that referenced this pull request Jun 16, 2020
@abdosi
[Submodule update] sonic-util
c656b4c 
 [201911][thermal control] Backport changes from master branch (#929)
     [201911][config] Support abbreviation (#933)
       Add 'hw-management-generate-dump.sh' to 'show techsupport'
       command (#934)
       [fwutil]: Update fwutil to v2.0.0.0. (#942)
       Fixes bug for PFCWD feature parameters (#838)
     Fixed fast-reboot for BFN platform (#871)
     [config] Add 'interface transceiver' subgroup with 'lpmode' and
     'reset' subcommands (#904)
      [warm-reboot]: added pre-check for ISSU file (#915)
       [config] Don't attempt to restart disabled services (#944)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@jleveque
[config] Don't attempt to restart disabled services (sonic-net#944)
a21e01a 
When restarting services, don't attempt to restart a service if it is disabled/masked or the `systemctl restart` command will fail, causing the calling command (e.g., `config load`, `config reload`, `config load_minigraph`) to error out.
@TACappleman TACappleman mentioned this pull request Oct 18, 2021
Merged
prsunny pushed a commit that referenced this pull request Oct 18, 2021
@TACappleman
[swss, swss-common, sairedis] submodule update (#8996)
c971fa7 
Sonic-swss-common:

[schema.h] Add trap flow counter support (#534) (sonic-net/sonic-swss-common@31f4253)
[schema] Add CBF table names (#525) (sonic-net/sonic-swss-common@b15e08d)

Sonic-sairedis:

[cbf] Add Class Based Forwarding support (#909) sonic-net/sonic-sairedis@ecb95a8
[azp] Enable pretty code coverage results xml (#946) sonic-net/sonic-sairedis@1148d16
[gearbox] startup gbsyncd in sync mode in vSonic (#939) sonic-net/sonic-sairedis@e59a085
[unittest] Add more Meta tests (#948) sonic-net/sonic-sairedis@812f7a5
[syncd] Fix SwitchNotifications to be const reference (#945) sonic-net/sonic-sairedis@5863ed3
[syncd] Refactor syncd request shutdown command line parser (#944) sonic-net/sonic-sairedis@d598dea
[unittest] Update meta tests (#943) sonic-net/sonic-sairedis@26b2237
[ci]: Support code diff coverage (#934) sonic-net/sonic-sairedis@e545b17
Sonic sairedis changes for SAI SRV6 and SAI refpoint update to v1.9.0 (#937) sonic-net/sonic-sairedis@921cf0b
[sairedis] Fail get/clear api on objects created in init view mode (#930) sonic-net/sonic-sairedis@362b34e
[vslib]: Remove invalid lane when create ports (#938) sonic-net/sonic-sairedis@db403f4
[Barefoot] enable bulk api`s in SAI (#927) sonic-net/sonic-sairedis@6df04d8
[unittest] Add NotificationBfdSessionStateChange tests (#940) sonic-net/sonic-sairedis@89d639b
[azp] Skip auto generated saimetadata lib code coverage (#935) sonic-net/sonic-sairedis@40e9c74
Remove tail white spaces sonic-net/sonic-sairedis@dabd1a7
Bring back pyext in Makefile.am sonic-net/sonic-sairedis@94d5545
Add RedisChannel tests sonic-net/sonic-sairedis@e16606a
Add RedisVidIndexGenerator tests sonic-net/sonic-sairedis@62b8fdd
Add ServerConfig tests sonic-net/sonic-sairedis@58725df
Add SkipRecordAttrContainer tests sonic-net/sonic-sairedis@6842d92
Update Switch tests sonic-net/sonic-sairedis@cd13f49
Add SwitchConfigContainer tests sonic-net/sonic-sairedis@6fc213d
Add SwitchConfigContainer tests sonic-net/sonic-sairedis@ee24c0e
Add SwitchContainer tests sonic-net/sonic-sairedis@e33c6e9
Add ZeroMQChannel tests sonic-net/sonic-sairedis@bcd1648
Add VirtualObjectIdManager tests sonic-net/sonic-sairedis@0a2cb2c
[sairedis] Remove legacy allocateSwitchIndex api sonic-net/sonic-sairedis@16fff7f

Sonic-swss:

[orchagent] Add separate next hop table and orch (#1702) sonic-net/sonic-swss@f248e26
[portorch]: Skip to create port if the lane set isn't available in ASIC (#1923) sonic-net/sonic-swss@fd0cafe
fix the type for SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE (#1942) sonic-net/sonic-swss@ef6b5d4
[cfgmgr] Fix for STATE_DB Port check (#1936) sonic-net/sonic-swss@b592ad7
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Dec 13, 2021
@yxieca
Merged PR 5235789: [manual merge] manual merge github/master into int…
74d52c5 
…ernal branch

Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022
@kcudnik
[syncd] Refactor syncd request shutdown command line parser (sonic-ne…
d598dea 
…t#944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@stcheng stcheng stcheng approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marian-pritsak @jleveque @lguohan @stcheng @msftclas