Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dockers][platform-monitor] Add chassis_db_init to platform monitor tasks #7596

Merged
merged 3 commits into from
May 28, 2021

Conversation

alexrallen
Copy link
Contributor

@alexrallen alexrallen commented May 12, 2021

Why I did it

I added chassis_db_init to the startup tasks for the docker-platform-monitor docker so that the script is run on startup of the switch and the chassis info is correctly provisioned to STATE_DB.

NOTE: THIS DEPENDS ON sonic-net/sonic-platform-daemons#183 DO NOT MERGE

How I did it

I modified the supervisord template in order to define the new task to be started.

How to verify it

Run sudo redis-cli -n 6 hgetall "CHASSIS_INFO|chassis 1"

Expected output (exact values will differ per platform)

1) "serial"
2) "MT1822K07815"
3) "model"
4) "MSN2700-CS2FO"
5) "revision"
6) "A1"
7) "psu_num"
8) "2"

Description for the changelog

[dockers][platform-monitor] Add chassis_db_init to platform monitor tasks

A picture of a cute animal (not mandatory but encouraged)

babycow

@alexrallen alexrallen requested a review from lguohan as a code owner May 12, 2021 18:54
@alexrallen alexrallen changed the title Chassisshow [dockers][platform-monitor] Add chassisshow to platform monitor tasks May 12, 2021
@jleveque
Copy link
Contributor

PR title mentions chassisshow, but PR description and content doesn't reflect this. Please update title and/or description as appropriate.

@alexrallen alexrallen changed the title [dockers][platform-monitor] Add chassisshow to platform monitor tasks [dockers][platform-monitor] Add chassis_db_init to platform monitor tasks May 12, 2021
@alexrallen
Copy link
Contributor Author

Whoops, copied from the internal system prior to the name change, thanks. Up to date now.

@liat-grozovik
Copy link
Collaborator

@robocoder99 as the dependent PR is merged, please check submodule is updated and then we can move forward with the merge process.

@liat-grozovik liat-grozovik requested a review from jleveque May 23, 2021 08:21
@alexrallen
Copy link
Contributor Author

Submodule bump PR is here #7709 may proceed once this merge completes. Please let me know if anything else is needed.

@jleveque jleveque merged commit 21b9fcc into sonic-net:master May 28, 2021
wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Jul 8, 2021
What is the motivation for this PR?
After sonic-net/sonic-buildimage#7596 have been merged test_watchdog_reboot started failing on check_pmon_daemons.

How did you do it?
Excluded chassis_db_init from checking as it is executed only one time and exiting.

How did you verify/test it?
Run watchdog_reboot. TC passed

Any platform specific information?
SONiC Software Version: SONiC.master.17861-dirty-20210602.081854
Distribution: Debian 10.9
Kernel: 4.19.0-12-2-amd64
Build commit: e50b6fc3
Build date: Wed Jun 2 13:33:37 UTC 2021

Platform: x86_64-arista_7170_64c
HwSKU: Arista-7170-64C
ASIC: barefoot

Signed-off-by: Roman Savchuk <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…asks (sonic-net#7596)

I added `chassis_db_init` to the startup tasks for the `docker-platform-monitor` docker so that the script is run on startup of the switch and the chassis info is correctly provisioned to STATE_DB.

Depends on sonic-net/sonic-platform-daemons#183
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
What is the motivation for this PR?
After sonic-net/sonic-buildimage#7596 have been merged test_watchdog_reboot started failing on check_pmon_daemons.

How did you do it?
Excluded chassis_db_init from checking as it is executed only one time and exiting.

How did you verify/test it?
Run watchdog_reboot. TC passed

Any platform specific information?
SONiC Software Version: SONiC.master.17861-dirty-20210602.081854
Distribution: Debian 10.9
Kernel: 4.19.0-12-2-amd64
Build commit: e50b6fc3
Build date: Wed Jun 2 13:33:37 UTC 2021

Platform: x86_64-arista_7170_64c
HwSKU: Arista-7170-64C
ASIC: barefoot

Signed-off-by: Roman Savchuk <[email protected]>
119064273 pushed a commit to 119064273/sonic-mgmt that referenced this pull request Jan 24, 2022
What is the motivation for this PR?
After sonic-net/sonic-buildimage#7596 have been merged test_watchdog_reboot started failing on check_pmon_daemons.

How did you do it?
Excluded chassis_db_init from checking as it is executed only one time and exiting.

How did you verify/test it?
Run watchdog_reboot. TC passed

Any platform specific information?
SONiC Software Version: SONiC.master.17861-dirty-20210602.081854
Distribution: Debian 10.9
Kernel: 4.19.0-12-2-amd64
Build commit: e50b6fc3
Build date: Wed Jun 2 13:33:37 UTC 2021

Platform: x86_64-arista_7170_64c
HwSKU: Arista-7170-64C
ASIC: barefoot

Signed-off-by: Roman Savchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants