[watermark] Fix error: BUFFER_POOL_WATERMARK isn't enabled by default #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
Co-authored-by: Mykola F <[email protected]>
liat-grozovik
approved these changes
Jul 7, 2020
|
@stephenxs is this required for 201911 as well? |
Yes, it is. |
mykolaf
approved these changes
Jul 7, 2020
|
@neethajohn , can you review? |
|
Is the intention of this PR to get the buffer pool watermark or to have the buffer pool watermark enabled by default in the image? You could just use 'counterpoll watermark enable' to enable the buffer pool watermark polling |
to have the buffer pool enabled by default in the image. |
neethajohn
approved these changes
Jul 11, 2020
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jul 12, 2020
…sonic-net#4882) * Fix error: watermarkstat -t buffer_pool doesn't work Signed-off-by: Stephen Sun <[email protected]>
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Sep 23, 2020
…sonic-net#4882) * Fix error: watermarkstat -t buffer_pool doesn't work Signed-off-by: Stephen Sun <[email protected]>
This was referenced Sep 23, 2020
[watermark] Fix error: BUFFER_POOL_WATERMARK isn't enabled by default…
stephenxs/sonic-buildimage#44
Closed
lguohan
pushed a commit
that referenced
this pull request
Sep 29, 2020
…#4882) (#5455) * Fix error: watermarkstat -t buffer_pool doesn't work Signed-off-by: Stephen Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Fix error: watermarkstat -t buffer_pool doesn't work
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)