[warmboot] Load database from redis-cli save
#2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenggen-xu
reviewed
Nov 21, 2018
| # Load loglevelDB from /host/warm-reboot/loglevel_db.json | ||
| redisLoadAndDelete 3 $WARM_DIR/loglevel_db.json | ||
| # Load redis content from /host/warm-reboot/dump.rdb | ||
| test -e $WARM_DIR/dump.rdb && docker cp $WARM_DIR/dump.rdb database:/var/lib/redis/dump.rdb |
There was a problem hiding this comment.
It seems the configdb-load.sh on database docker will load the config_db.json again, which is redundant to this dump.rdb, it may actually have different config if people forget to do cli save. Should we do something special treatment for warm boot in in configdb-load.sh? #Resolved
There was a problem hiding this comment.
yxieca
approved these changes
Nov 21, 2018
lguohan
reviewed
Nov 22, 2018
| priority=2 | ||
| autostart=true | ||
| autorestart=false | ||
| stdout_logfile=syslog | ||
| stderr_logfile=syslog | ||
|
|
||
| [program:configdb-load.sh] |
There was a problem hiding this comment.
configdb-load is also used in virtual switch, can you change that too? #WontFix
There was a problem hiding this comment.
I would like keep behavior unchange on vs side, and visit the warm-reboot feature later.
Also applied to P4 side.
In reply to: 235583086 [](ancestors = 235583086)
lguohan
approved these changes
Nov 22, 2018
yxieca
approved these changes
Nov 22, 2018
zhenggen-xu
approved these changes
Nov 22, 2018
Signed-off-by: Qi Luo <[email protected]>
Signed-off-by: Qi Luo <[email protected]>
…se to file Signed-off-by: Qi Luo <[email protected]>
Signed-off-by: Qi Luo <[email protected]>
Signed-off-by: Qi Luo <[email protected]>
qiluo-msft
force-pushed
the
qiluo/redisdump
branch
from
c9dc890 to
b9ce074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-utilities#389
This is a disruptive change.