[healthd] Added change to handle Feature Table exception #19480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 598ab99. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
…)" This reverts commit c11ab02.
Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Basically handle any exception when calling API get_device_runtime_metadata() and go for retry. Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
changed the title
abdosi
changed the title
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@bingwang-ms : Can you help review this. |
bingwang-ms
approved these changes
Jul 9, 2024
|
@dgsudharsan Can you help review this change? |
dgsudharsan
approved these changes
Jul 10, 2024
|
@bingwang-ms : please help with merge of this and cherry-pick to 202405. |
|
[like] Rita Hui reacted to your message:
…________________________________
From: abdosi ***@***.***>
Sent: Saturday, July 13, 2024 1:53:23 AM
To: sonic-net/sonic-buildimage ***@***.***>
Cc: Rita Hui ***@***.***>; Mention ***@***.***>
Subject: Re: [sonic-net/sonic-buildimage] [healthd] Added change to handle Feature Table exception (PR #19480)
@rlhui<https://github.com/rlhui> / @lguohan<https://github.com/lguohan> : can you help with sign-off/merge of this PR.
—
Reply to this email directly, view it on GitHub<#19480 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALT3ETR5T2NJUHS24Y5AMTTZMCCBHAVCNFSM6AAAAABKME6AFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWG4YDGNRYG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…9480) *Fix: sonic-net#18818 Handle any exception in API get_service_from_feature_table() gracefully . --------- Signed-off-by: Abhishek Dosi <[email protected]>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…9480) *Fix: sonic-net#18818 Handle any exception in API get_service_from_feature_table() gracefully . --------- Signed-off-by: Abhishek Dosi <[email protected]>
|
enhancement, no cherry pick for 202305 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 2, 2024
…9480) *Fix: sonic-net#18818 Handle any exception in API get_service_from_feature_table() gracefully . --------- Signed-off-by: Abhishek Dosi <[email protected]>
|
Cherry-pick PR to 202311: #19785 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 2, 2024
…9480) *Fix: sonic-net#18818 Handle any exception in API get_service_from_feature_table() gracefully . --------- Signed-off-by: Abhishek Dosi <[email protected]>
|
Cherry-pick PR to 202405: #19787 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 3, 2024
*Fix: #18818 Handle any exception in API get_service_from_feature_table() gracefully . --------- Signed-off-by: Abhishek Dosi <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Aug 24, 2024
*Fix: #18818 Handle any exception in API get_service_from_feature_table() gracefully . --------- Signed-off-by: Abhishek Dosi <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Fix: #18818
How I did:
Handle any exception in API
get_service_from_feature_table()gracefully .How I verify:
Manual Verification.