Fix yang model for ICMP and ICMPV6 #18311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueve
approved these changes
Mar 9, 2024
lizhijianrd
approved these changes
Mar 9, 2024
ganglyu
reviewed
Mar 11, 2024
ganglyu
approved these changes
Mar 11, 2024
wen587
approved these changes
Mar 11, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
* Fix yang model for ICMP and ICMPV6 * Change ICMP type and code to 0-255
|
Cherry-pick PR to 202311: #18327 |
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
* Fix yang model for ICMP and ICMPV6 * Change ICMP type and code to 0-255
|
hi @bingwang-ms is this must to have? I'm trying to keep only must fix in at this stage. |
|
@bingwang-ms cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 15, 2024
* Fix yang model for ICMP and ICMPV6 * Change ICMP type and code to 0-255
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 9, 2024
* Fix yang model for ICMP and ICMPV6 * Change ICMP type and code to 0-255
|
Cherry-pick PR to 202305: #18921 |
mssonicbld
pushed a commit
that referenced
this pull request
May 11, 2024
* Fix yang model for ICMP and ICMPV6 * Change ICMP type and code to 0-255
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix #18137
This PR is to update the definition of Yang model for ICMP and ICMPv6.
References
Work item tracking
How I did it
How to verify it
Verified by UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Update the definition of Yang model for ICMP and ICMPv6.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)