Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bcmsh issues. #1761

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Fix the bcmsh issues. #1761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions platform/broadcom/docker-syncd-brcm.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ $(DOCKER_SYNCD_BRCM)_RUN_OPT += -v /var/run/docker-syncd:/var/run/sswsyncd
$(DOCKER_SYNCD_BRCM)_RUN_OPT += -v /etc/sonic:/etc/sonic:ro

$(DOCKER_SYNCD_BRCM)_BASE_IMAGE_FILES += bcmcmd:/usr/bin/bcmcmd
$(DOCKER_SYNCD_BRCM)_BASE_IMAGE_FILES += bcmsh:/usr/bin/bcmsh
Copy link
Collaborator

@qiluo-msft qiluo-msft Jun 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bcmsh [](start = 56, length = 5)

I think bcmsh script will not work in host, because the domain socket is in a different place there. #Closed

Copy link
Collaborator Author

@zhenggen-xu zhenggen-xu Jun 5, 2018 •
edited by qiluo-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree here. The script in the change is not the original script inside docker, it is as below:

#!/bin/bash
docker exec -i syncd bcmsh "$@"

It calls the script inside the docker and the same domain socket is used.
Everything works fine from host side, and people don't need go to docker to type the command.
#Closed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just found I wrote the wrapper:)

In reply to: 193163581 [](ancestors = 193163581)

Copy link
Collaborator Author

@zhenggen-xu zhenggen-xu Jun 5, 2018 •
edited by qiluo-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still marked as "Changes requested", can you remove that? #Closed