Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tacacs] User with priv_lvl 0 should not be in docker group #1626

Merged
merged 1 commit into from
Apr 21, 2018
Merged

[tacacs] User with priv_lvl 0 should not be in docker group #1626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tacacs/nss/0001-Modify-user-map-profile.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,9 +564,9 @@ index 79e62b9..ecfa0b0 100644
+ useradd_info_t *user;
+
+ user = &useradd_grp_list[MIN_TACACS_USER_PRIV];
+ user->gid = 999;
+ user->gid = 100;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 100 conflict with existing groups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a linux built-in group ('user') and I don't think it is used anywhere in sonic.

+ user->info = strdup("remote_user");
+ user->secondary_grp = strdup("docker");
+ user->secondary_grp = strdup("users");
+ user->shell = strdup("/bin/bash");
+
+ user = &useradd_grp_list[MAX_TACACS_USER_PRIV];
Expand Down