Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-ptf]: Use py2-ipaddress instead of ipaddress package #1149

Closed
wants to merge 1 commit into from
Closed

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Nov 13, 2017

Signed-off-by: Shu0T1an ChenG [email protected]

@stcheng stcheng requested a review from lguohan November 13, 2017 21:47
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@jleveque
Copy link
Contributor

What is the goal of this change?

@lguohan
Copy link
Collaborator

lguohan commented Nov 13, 2017

does this change break the test?

@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@sonic-net sonic-net deleted a comment from svc-acs Nov 13, 2017
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build finished. No test results found.

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change break the test?

@stcheng
Copy link
Contributor Author

stcheng commented Nov 17, 2017

i'll generate this pull request only when needed in the future.

@stcheng stcheng closed this Nov 17, 2017
lguohan pushed a commit that referenced this pull request Mar 29, 2021
- 4d89510 - 2021-3-28 | [reboot] User-friendly reboot cause message for kernel panic (#1486) [Yong Zhao]
- 1f1696a - 2021-3-26 | Add all parameter to show/clear queue watermark command (#1149) [ Petro Bratash]

Signed-off-by: Yong Zhao <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
…t#1149)

Signed-off-by: Petro Bratash [email protected]
Depends on sonic-net/sonic-swss#1653

- What I did
Add new commands :
show queue persistent-watermark all
show queue watermark all
sonic-clear queue watermark all
sonic-clear queue persistent-watermark all

- How I did it
Add q_shared_all type to watermarkstat file

- How to verify it
Execute:
show queue persistent-watermark all
show queue watermark all
sonic-clear queue watermark all
sonic-clear queue persistent-watermark all
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
- 4d89510 - 2021-3-28 | [reboot] User-friendly reboot cause message for kernel panic (sonic-net#1486) [Yong Zhao]
- 1f1696a - 2021-3-26 | Add all parameter to show/clear queue watermark command (sonic-net#1149) [ Petro Bratash]

Signed-off-by: Yong Zhao <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
- 4d89510 - 2021-3-28 | [reboot] User-friendly reboot cause message for kernel panic (sonic-net#1486) [Yong Zhao]
- 1f1696a - 2021-3-26 | Add all parameter to show/clear queue watermark command (sonic-net#1149) [ Petro Bratash]

Signed-off-by: Yong Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants