Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnet route added for management interface (eth0) - "fixes #1023" #1142

Merged
merged 5 commits into from
Nov 14, 2017
Merged

Subnet route added for management interface (eth0) - "fixes #1023" #1142

merged 5 commits into from
Nov 14, 2017

Conversation

prsunny
Copy link
Contributor

@prsunny prsunny commented Nov 10, 2017

- What I did
Added a subnet route in "default" kernel route table based on the IP address/prefix of management interface (eth0)

- How I did it
Modified the interface.j2 template to add/delete subnet route for eth0

- How to verify it
Execute the following command:

admin@str-acs-10:~$ ip route show table default
default via 10.64.246.1 dev eth0 
10.64.246.0/23 dev eth0  scope link

admin@str-acs-10:~$ sudo ifdown eth0
admin@str-acs-10:~$ ip route show table default
admin@str-acs-10:~$ 
admin@str-acs-10:~$ sudo ifup eth0
Waiting for DAD... Done
admin@str-acs-10:~$ 
admin@str-acs-10:~$ ip route show table default
default via 10.64.246.1 dev eth0 
10.64.246.0/23 dev eth0  scope link 
admin@str-acs-10:~$ 

Note: Instead of "ifdown/ifup", if interface is shut using "ifconfig eth0 down" or "ip link set dev eth0 down" and then "ifconfig eth0 up", then these entries will be deleted from the default route table and you've to restart network service to reconfigure the route entries.

- Description for the changelog
Added subnet route to default route table in kernel for management interface

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Nov 12, 2017

cfg engine unit test is broken, can you check?

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build triggered. sha1 is merged.

2 similar comments
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build triggered. sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build triggered. sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build started sha1 is merged.

2 similar comments
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build started sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build started sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build finished. No test results found.

1 similar comment
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build finished. No test results found.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

No test results found.

@lguohan
Copy link
Collaborator

lguohan commented Nov 13, 2017

cfggen test still fails?

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build triggered. sha1 is merged.

2 similar comments
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build triggered. sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 13, 2017

Build triggered. sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build started sha1 is merged.

2 similar comments
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build started sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build started sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build finished. No test results found.

1 similar comment
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build finished. No test results found.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

No test results found.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build triggered. sha1 is merged.

2 similar comments
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build triggered. sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build triggered. sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build started sha1 is merged.

2 similar comments
@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build started sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build started sha1 is merged.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

No test results found.

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build finished. No test results found.

@prsunny
Copy link
Contributor Author

prsunny commented Nov 14, 2017

@lguohan, fixed the cfggen test issue. Can you please review?

@svc-acs
Copy link
Collaborator

svc-acs commented Nov 14, 2017

Build finished. No test results found.

@lguohan lguohan merged commit 803c263 into sonic-net:master Nov 14, 2017
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Dec 20, 2019
9f6efa0 [port/buffer] introduce a sync mechanism to protect port
PG/queue from changes under PFC storm (sonic-net#1143)
823e426 [aclorch] Enable DSCP rules on IPv6 mirror tables (sonic-net#1146)
b8745f8 [bitmap_vnet]: Fix removal flow for tunnel route (sonic-net#1139)
03be983 Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)
a4a1d3b [vnet]: Update VNET route table size to 40K for BITMAP
implementation (sonic-net#1132)
efe142a Fix bug: Wrong condition for mac address (sonic-net#1142)
7bf63a0 [teammgrd]during warm-reboot teamd need to recover system-id
from saved lacp-pdu (sonic-net#1003)
8b4cfb6 Cleanup configure.ac from BFN specific code (sonic-net#1133)
b931751 [teamsyncd]: Add retry logic in teamsyncd to avoid team handler
init failure (sonic-net#854)

Signed-off-by: Stepan Blyschak <[email protected]>
lguohan pushed a commit that referenced this pull request Dec 27, 2019
9f6efa0 [port/buffer] introduce a sync mechanism to protect port
PG/queue from changes under PFC storm (#1143)
823e426 [aclorch] Enable DSCP rules on IPv6 mirror tables (#1146)
b8745f8 [bitmap_vnet]: Fix removal flow for tunnel route (#1139)
03be983 Increase ip2me CIR/CBR for faster in-band file transfers (#1000)
a4a1d3b [vnet]: Update VNET route table size to 40K for BITMAP
implementation (#1132)
efe142a Fix bug: Wrong condition for mac address (#1142)
7bf63a0 [teammgrd]during warm-reboot teamd need to recover system-id
from saved lacp-pdu (#1003)
8b4cfb6 Cleanup configure.ac from BFN specific code (#1133)
b931751 [teamsyncd]: Add retry logic in teamsyncd to avoid team handler
init failure (#854)

Signed-off-by: Stepan Blyschak <[email protected]>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
lguohan pushed a commit that referenced this pull request Oct 6, 2020
- [acl-loader] Revert fix for IP protocol == 0 (#1142)
- Show sflow interface to display all interfaces enabled for sflow (#1143)
- [sflow_test.py]: tests for config sflow commands. (#1112)
- [config/console] Support add/del console port setting commands (#1136)
- [cli][bgp]use vtysh in the show ip bgp summary command (#1137)
- [README.md] Describe new package creation schema (#1131)
- [consutil] Remove actual baud and refactor lib for future change (#1130)

Signed-off-by: Danny Allen <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…t#5545)

- [acl-loader] Revert fix for IP protocol == 0 (sonic-net#1142)
- Show sflow interface to display all interfaces enabled for sflow (sonic-net#1143)
- [sflow_test.py]: tests for config sflow commands. (sonic-net#1112)
- [config/console] Support add/del console port setting commands (sonic-net#1136)
- [cli][bgp]use vtysh in the show ip bgp summary command (sonic-net#1137)
- [README.md] Describe new package creation schema (sonic-net#1131)
- [consutil] Remove actual baud and refactor lib for future change (sonic-net#1130)

Signed-off-by: Danny Allen <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants