-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Move hostname, mgmt interface/vrf config to hostcfgd #10868
Conversation
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
@fastiuk coulld you please edit the PR subject? can you make it clea what is moved? also please note that chnages under sonic-utilities should be placed as a PR aginst sonic-utiltiies repro and once merged you can have submoudle update PR on sonib-buildimage. If there is a dependcy on the PRs please add it to the description |
d1d1162
to
88e348a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add UT for mgmt interface/vrf
@fastiuk when do you think the UT can be added so hthis change can get in? |
Signed-off-by: Yevhen Fastiuk <[email protected]>
46adc4c
to
5507998
Compare
Done |
@liat-grozovik By the way, since this MR depends on sonic-utilities, should it contain a submodule commit or I will need to update it later in the same way as without dependency? |
@lguohan could you please help to review or assing someone to do so? |
I think conflicts can't be resolved here anymore, cause the code was moved to the submodule. |
This PR depends on sonic-net/sonic-utilities#2173
Why I did it
To be able to configure the management interface and hostname standalone by changing database config at runtime.
From the CLI perspective fo view, the following behavior is the same. But now you have two ways of configuring it: CLI, directly through the database.
How I did it
Moved configuration part of the interface and hostname to "hostcfgd".
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Submodules PR's :
A picture of a cute animal (not mandatory but encouraged)