Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dhcp6relay to be a submodule, and rename it to dhcprelay #10711

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

saiarcot895
Copy link
Contributor

@saiarcot895 saiarcot895 commented Apr 28, 2022

Signed-off-by: Saikrishna Arcot [email protected]

Why I did it

src/dhcprelay is being split out to be its own submodule.

How I did it

  1. Add existing dhcprelay commits into the new repo.
  2. Clean up Makefile (sonic-net/sonic-dhcp-relay@772625f)
  3. Add LGTM config (sonic-net/sonic-dhcp-relay@5cc0889)
  4. Add Azure pipeline config (sonic-net/sonic-dhcp-relay@c79cdb7)
  5. Add submodule reference, renaming most references of dhcp6relay to dhcprelay (to reflect that this will not just be for IPv6 in the future).

How to verify it

Successful run of LGTM is tested at sonic-net/sonic-dhcp-relay#4. Failure run of LGTM is tested at sonic-net/sonic-dhcp-relay#3.

Azure pipeline is run for each commit/PR, and will build for amd64, armhf, and arm64. UT/code coverage check is not yet done.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@saiarcot895 saiarcot895 requested review from yxieca and kellyyeh April 29, 2022 01:53
@saiarcot895 saiarcot895 marked this pull request as ready for review April 29, 2022 01:53
@saiarcot895 saiarcot895 force-pushed the dhcprelay-submodule branch 2 times, most recently from 0b1f11d to 709e570 Compare May 6, 2022 06:14
@saiarcot895
Copy link
Contributor Author

Updated to include the latest dhcp6relay changes.

kellyyeh
kellyyeh previously approved these changes May 17, 2022
@saiarcot895 saiarcot895 force-pushed the dhcprelay-submodule branch from 6b1d601 to 8cc1c9c Compare July 8, 2022 21:16
@yxieca yxieca merged commit f4d9c94 into sonic-net:master Jul 12, 2022
@saiarcot895 saiarcot895 deleted the dhcprelay-submodule branch July 12, 2022 17:40
yxieca pushed a commit that referenced this pull request Aug 9, 2022
Why I did it
src/dhcprelay is being split out to be its own submodule.

How I did it
Add existing dhcprelay commits into the new repo.
Clean up Makefile (sonic-net/sonic-dhcp-relay@772625f)
Add LGTM config (sonic-net/sonic-dhcp-relay@5cc0889)
Add Azure pipeline config (sonic-net/sonic-dhcp-relay@c79cdb7)
Add submodule reference, renaming most references of dhcp6relay to dhcprelay (to reflect that this will not just be for IPv6 in the future).
How to verify it
Successful run of LGTM is tested at sonic-net/sonic-dhcp-relay#4. Failure run of LGTM is tested at sonic-net/sonic-dhcp-relay#3.

Azure pipeline is run for each commit/PR, and will build for amd64, armhf, and arm64. UT/code coverage check is not yet done.

Signed-off-by: Saikrishna Arcot <[email protected]>
skbarista pushed a commit to skbarista/sonic-buildimage that referenced this pull request Aug 17, 2022
…c-net#10711)

Why I did it
src/dhcprelay is being split out to be its own submodule.

How I did it
Add existing dhcprelay commits into the new repo.
Clean up Makefile (sonic-net/sonic-dhcp-relay@772625f)
Add LGTM config (sonic-net/sonic-dhcp-relay@5cc0889)
Add Azure pipeline config (sonic-net/sonic-dhcp-relay@c79cdb7)
Add submodule reference, renaming most references of dhcp6relay to dhcprelay (to reflect that this will not just be for IPv6 in the future).
How to verify it
Successful run of LGTM is tested at sonic-net/sonic-dhcp-relay#4. Failure run of LGTM is tested at sonic-net/sonic-dhcp-relay#3.

Azure pipeline is run for each commit/PR, and will build for amd64, armhf, and arm64. UT/code coverage check is not yet done.

Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants