From d81abd5af917201a3de918af552c4e2ba4357c27 Mon Sep 17 00:00:00 2001 From: Junchao-Mellanox Date: Wed, 31 Jul 2024 04:39:12 +0300 Subject: [PATCH] Fix review comments --- src/sonic-py-common/sonic_py_common/syslogger.py | 4 ++-- src/sonic-py-common/tests/test_syslogger.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sonic-py-common/sonic_py_common/syslogger.py b/src/sonic-py-common/sonic_py_common/syslogger.py index 8968807706bc..b921f738691b 100644 --- a/src/sonic-py-common/sonic_py_common/syslogger.py +++ b/src/sonic-py-common/sonic_py_common/syslogger.py @@ -125,7 +125,7 @@ def log_priority_to_str(self, priority): return 'ERROR' else: self.log_error(f'Invalid log priority: {priority}') - return 'NOTICE' + return 'WARN' def log_priority_from_str(self, priority_in_str): """Convert log priority from string. @@ -146,7 +146,7 @@ def log_priority_from_str(self, priority_in_str): return logging.ERROR else: self.log_error(f'Invalid log priority string: {priority_in_str}') - return logging.NOTICE + return logging.WARNING def set_min_log_priority(self, priority): """ diff --git a/src/sonic-py-common/tests/test_syslogger.py b/src/sonic-py-common/tests/test_syslogger.py index 428cec6fbb0c..849d2c132bf5 100644 --- a/src/sonic-py-common/tests/test_syslogger.py +++ b/src/sonic-py-common/tests/test_syslogger.py @@ -55,7 +55,7 @@ def test_log_priority_from_str(self): assert log.log_priority_from_str('NOTICE') == logging.NOTICE assert log.log_priority_from_str('WARN') == logging.WARN assert log.log_priority_from_str('DEBUG') == logging.DEBUG - assert log.log_priority_from_str('invalid') == logging.NOTICE + assert log.log_priority_from_str('invalid') == logging.WARN def test_log_priority_to_str(self): log = syslogger.SysLogger() @@ -64,7 +64,7 @@ def test_log_priority_to_str(self): assert log.log_priority_to_str(logging.DEBUG) == 'DEBUG' assert log.log_priority_to_str(logging.WARN) == 'WARN' assert log.log_priority_to_str(logging.ERROR) == 'ERROR' - assert log.log_priority_to_str(-1) == 'NOTICE' + assert log.log_priority_to_str(-1) == 'WARN' @mock.patch('swsscommon.swsscommon.SonicV2Connector') def test_runtime_config(self, mock_connector):