From 31ca0ea599422798469758e80c088a63fcbb1b8c Mon Sep 17 00:00:00 2001 From: Mai Bui Date: Wed, 28 Sep 2022 09:51:26 -0700 Subject: [PATCH] Remove shell=True (#313) Signed-off-by: maipbui Signed-off-by: maipbui --- sonic_platform_base/sonic_pcie/pcie_common.py | 8 ++++---- tests/pcie_common_test.py | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sonic_platform_base/sonic_pcie/pcie_common.py b/sonic_platform_base/sonic_pcie/pcie_common.py index 58590ea8cef9..127c614cde17 100644 --- a/sonic_platform_base/sonic_pcie/pcie_common.py +++ b/sonic_platform_base/sonic_pcie/pcie_common.py @@ -39,14 +39,14 @@ def get_pcie_device(self): pciList = [] p1 = "^(\w+):(\w+)\.(\w)\s(.*)\s*\(*.*\)*" p2 = "^.*:.*:.*:(\w+)\s*\(*.*\)*" - command1 = "sudo lspci" - command2 = "sudo lspci -n" + command1 = ["sudo", "lspci"] + command2 = ["sudo", "lspci", "-n"] # run command 1 - proc1 = subprocess.Popen(command1, shell=True, universal_newlines=True, stdout=subprocess.PIPE) + proc1 = subprocess.Popen(command1, universal_newlines=True, stdout=subprocess.PIPE) output1 = proc1.stdout.readlines() (out, err) = proc1.communicate() # run command 2 - proc2 = subprocess.Popen(command2, shell=True, universal_newlines=True, stdout=subprocess.PIPE) + proc2 = subprocess.Popen(command2, universal_newlines=True, stdout=subprocess.PIPE) output2 = proc2.stdout.readlines() (out, err) = proc2.communicate() diff --git a/tests/pcie_common_test.py b/tests/pcie_common_test.py index a9cac55bd092..9334584b92df 100644 --- a/tests/pcie_common_test.py +++ b/tests/pcie_common_test.py @@ -131,9 +131,9 @@ class TestPcieCommon: def test_get_pcie_devices(self, subprocess_popen_mock): def subprocess_popen_side_effect(*args, **kwargs): - if args[0] == 'sudo lspci': + if args[0] == ['sudo', 'lspci']: output = lspci_output.splitlines() - elif args[0] == 'sudo lspci -n': + elif args[0] == ['sudo', 'lspci', '-n']: output = lspci_ID_output.splitlines() popen_mock = mock.Mock()