Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HLD for OC Yang interfaces. #1628

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

nagarwal03
Copy link
Contributor

@nagarwal03 nagarwal03 commented Mar 6, 2024

What we did:
Added transformer support for OpenConfig Interfaces.

Why we did it?
Earlier, intf_app.go was used for interfaces configuration. Replacing it with xfmr_intf.go to add transformer support for OpenConfig YANG interfaces configuration via REST and gNMI.

Support added:

  1. Provide support for OpenConfig Interfaces YANG models.
  2. Replace translib App based implementation with a Transformer based implementation of:
    • Get Ethernet interface attributes.
    • Configure/ Set Ethernet interface attributes.
    • Delete Ethernet interface attributes.
  3. Ethernet interface parameters can be modified via REST and gNMI.
  4. Support port-speed and auto-negotiation on Ethernet interfaces via REST and gNMI.
  5. Support IPv4 and IPv6 address configuration on Ethernet interfaces via REST and gNMI.
  6. This does not cover gNMI subscription. This is planned for the next phase.

Corresponding coding PR:
sonic-mgmt-common changes

nagarwal03 and others added 2 commits March 6, 2024 14:48
Copy link

linux-foundation-easycla bot commented Mar 6, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@adyeung
Copy link
Collaborator

adyeung commented Mar 15, 2024

@sayedsaquibbrcm will help review

@sayedsaquibbrcm
Copy link

Why are we not supporting Vlan interfaces?

@bhavini-gada
Copy link

Why are we not supporting Vlan interfaces?

First interface type being supported is physical.

@adyeung adyeung merged commit c250757 into sonic-net:master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants