Handle relative URLs #224
Merged
Handle relative URLs #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthHater
requested review from
bhamail,
allenhsieh,
ButterB0wl and
Slim-Shary
ButterB0wl
approved these changes
Feb 12, 2021
brent-spiner
pushed a commit
that referenced
this pull request
Feb 12, 2021
## [4.0.24](v4.0.23...v4.0.24) (2021-02-12) ### Bug Fixes * Handle relative URLs ([#224](#224)) ([c2e192c](c2e192c))
|
🎉 This PR is included in version 4.0.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles relative URLs
This pull request makes the following changes:
new URLusing the reportHtmlUrl and the host for IQ Server, returns thehrefproperty for itApproach stolen from: https://stackoverflow.com/a/16301947/338597
new URL will ignore the provided base if the first URL is absolute, voila!
cc @bhamail / @DarthHater / @allenhsieh / @ken-duck