Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 5 support #463

Closed
gam6itko opened this issue Jun 1, 2020 · 10 comments
Closed

Symfony 5 support #463

gam6itko opened this issue Jun 1, 2020 · 10 comments

Comments

@gam6itko
Copy link

gam6itko commented Jun 1, 2020

Feature Request

Are you planning to add support for Symfon5?

@core23
Copy link
Member

core23 commented Jun 1, 2020

Are you planning to add support for Symfon5?

Yes, but no one has started it. Maybe you can help @gam6itko ?

@jorrit
Copy link
Contributor

jorrit commented Jun 2, 2020

A while ago I started with it on https://github.com/jorrit/SonataFormatterBundle/tree/symfony5, but the dev dependencies media-bundle and admin-bundle are not compatible with Symfony 5 yet.
These bundles are only needed for CkeditorAdminController and CkeditorAdminControllerTest. Perhaps the tests can be made optional somehow, otherwise it will take a while before the formatter bundle is compatible with Symfony 5.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@medsalah91
Copy link

Hello, Are you planning to add this issu ?

@core23
Copy link
Member

core23 commented Jun 14, 2021

Hello, Are you planning to add this issu ?

We as the core team / reviewers are not actively working on the issue at the moment. Maybe you can help to finish this @medsalah91

@core23 core23 removed the stale label Jun 14, 2021
@VincentLanglet
Copy link
Member

We currently are working on the SonataMediaBundle, which is a requirement for this.

@balazscsaba2006
Copy link

@core23 Since MediaBundle has already support for ^5.3, can this PR #622 be merged? Do you need help with it?

@ger86
Copy link

ger86 commented Dec 17, 2021

I have added support por SF 5.3 in this branch:

https://github.com/ger86/SonataFormatterBundle/tree/symfony5

It contains more changes than provided by @balazscsaba2006 to fix some errors. Do you want me to create a PR?

@VincentLanglet
Copy link
Member

Any help on sonata-project/dev-kit#1715 is welcomed.

But be sure to target the 5.x branch since adding support for Sonata 4/Symfony 5 will introduce some BC break I think.

@VincentLanglet
Copy link
Member

5.x now support Sf5, feel free to try this unstable branch until we finished a stable release (it will still take some time)

@VincentLanglet VincentLanglet unpinned this issue Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants