-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SteamVR button #43
Comments
I wouldn't mind having both buttons moved up there. BPM doesn't need such a big button at the edge of the screen, and without that button there, there's no reason for the URL bar area to be so tall. Speaking of (re)moving buttons, why is there a dedicated 'add a game' menu at the bottom of the window? It's hardly a frequently-used important function, and all the items in it are in the Games menu. |
Sorry, I wasn't aware of this issue earlier. I'll work on a fix for it tomorrow. I think the best thing to do (unless someone is willing to make a custom icon) is to use the default big picture mode button that was added as an override and just add the VR button next to it. Edit: |
For some reason, I am unable to see the Steam VR button even in the default skin. Is there anything I need to do to enable it? Without the ability to see it, I won't be able to fix it. |
I believe it only shows up when you have a VR device attached. You would need to disable that behaviour during development I guess, or make a dummy button, position that, and copy the settings over to the VR button. |
@Clavus, Have you tested to see what it looks like when you activate Steam VR mode? It appears there is also an "Exit VR" button that needs to be included as well. At least that's what I'm seeing in the code. |
Can't test it myself until Monday. Another thing: brother said the VR button showed up for him and he doesn't have VR hardware. Are you testing on the steam beta branch? |
@Clavus, Yes, I am on the beta branch. Has he ever used VR on his PC? If not, is there anything VR related that he's downloaded? |
Maybe if you download SteamVR in the tools tab? He also just moved to Windows 10 but that's probably not related. |
@Clavus, Well, I downloaded SteamVR and VRMonitor and tried to run SteamVR but was just brought to some blue setup looking screen. Doubt I'll be able to set anything up without the VR Hardware. I still don't see a button, so I'm kind of at a loss here. If I can't get this to work for me, then someone who has it working will have to fix it. It's a relatively simple fix. |
I actually tinkered with it a bit earlier, but somehow my button remained in the top bar instead of next to the big picture button. But anyway, if nobody else can fix it I'll give it another go on Monday. |
I too can see it without any VR hardware, not sure what's causing it. I'll try to have a go at this tomorrow. |
@somini, Well all they do there is hide the VR button for some reason instead of adding it. I could do that without being able to see it. They might be hiding it because there's another way they've decided to access VR mode. I know the creator of that skin so I'll just ask him about it tomorrow. I'll let you know what I find out. |
I spoke with Dirt Diglett and he told me he hid the VR button so that he could later add it into a drop-down menu since he thinks there are very few people that will make use of the feature. I don't think this is a bad idea either. This way we won't have to remove the custom Big Picture button, so we won't have to adjust the ini file to change the Big Picture button to the default one and create room for the VR button. Let me know what you think of this, @somini. |
Looks good to me. Just add a line to the README to let people know. |
text font doesn t match but i wish keep the same spirit |
@SHOUBISHOCK how did you get this? |
I at least am not sure what you are referring to |
Ohh |
There was a beta update that added a SteamVR button.
I think the best place to put it would be to the left of the Big Picture mode, just like the default skin.
The text was updated successfully, but these errors were encountered: