Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Solvuu-build installs generic modules globally #57

Closed
copy opened this issue Feb 21, 2017 · 6 comments
Closed

Solvuu-build installs generic modules globally #57

copy opened this issue Feb 21, 2017 · 6 comments

Comments

@copy
Copy link
Contributor

copy commented Feb 21, 2017

solvuu-build installs its helper modules (like Tools, Util), which are already included in the pack. This can cause conflicts with other libraries and triggers this bug when using solvuu-build as a library.

~ % ls .opam/4.04.0+flambda/lib/solvuu-build/*.cmx
.opam/4.04.0+flambda/lib/solvuu-build/project.cmx               .opam/4.04.0+flambda/lib/solvuu-build/std.cmx
.opam/4.04.0+flambda/lib/solvuu-build/solvuu_build.cmx          .opam/4.04.0+flambda/lib/solvuu-build/tools.cmx
.opam/4.04.0+flambda/lib/solvuu-build/solvuu_build_eliom.cmx    .opam/4.04.0+flambda/lib/solvuu-build/util.cmx
.opam/4.04.0+flambda/lib/solvuu-build/solvuu_build_findlib.cmx

@agarwal
Copy link
Member

agarwal commented Feb 25, 2017

I've pushed a new branch issue-57, which stops installing cmi, cmo, cmx, and .o files. I believe that other files such as annot, cmt and cmti should still be installed, at least that is how Core does it.

If you confirm this solves your problem, I'll merge to master.

@copy
Copy link
Contributor Author

copy commented Feb 27, 2017

The branch fixes this issue for me, cheers!

@pveber
Copy link
Contributor

pveber commented Feb 27, 2017

@agarwal I guess you mean cmi, cmo, cmx and o files from packed modules only, right?

@agarwal
Copy link
Member

agarwal commented Feb 27, 2017

I guess you mean cmi, cmo, cmx and o files from packed modules only, right?

Right, yes.

@pveber
Copy link
Contributor

pveber commented Feb 27, 2017

Then I agree it should be harmless at worst.

@agarwal
Copy link
Member

agarwal commented Feb 27, 2017

Fixed in 88b92da, which has now been merged to master.

@agarwal agarwal closed this as completed Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants