From 69e28ca5206ee904b1f47ab35d0bcee9066c43f5 Mon Sep 17 00:00:00 2001
From: Thomas von Deyen <thomas@vondeyen.com>
Date: Tue, 25 Jul 2017 15:40:39 +0200
Subject: [PATCH] Fix the address retrieval on the PayPal payload

PayPal does not always send a shipping address with the payload, often only a billing address is available (ie. Using the paypal test sandbox).

This fixes this by first trying to use the shippingAddress and if that is not available use the billingAddress instead.
---
 .../solidus_paypal_braintree/paypal_button.js | 31 ++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/app/assets/javascripts/solidus_paypal_braintree/paypal_button.js b/app/assets/javascripts/solidus_paypal_braintree/paypal_button.js
index cfd5a7e7..80d9fb69 100644
--- a/app/assets/javascripts/solidus_paypal_braintree/paypal_button.js
+++ b/app/assets/javascripts/solidus_paypal_braintree/paypal_button.js
@@ -91,24 +91,27 @@ SolidusPaypalBraintree.PaypalButton.prototype._transactionParams = function(payl
  * @param {object} payload - The payload returned by Braintree after tokenization
  */
 SolidusPaypalBraintree.PaypalButton.prototype._addressParams = function(payload) {
-  if (payload.details.shippingAddress.recipientName) {
-    var first_name = payload.details.shippingAddress.recipientName.split(" ")[0];
-    var last_name = payload.details.shippingAddress.recipientName.split(" ")[1];
+  var first_name, last_name;
+  var payload_address = payload.details.shippingAddress || payload.details.billingAddress;
+
+  if (payload_address.recipientName) {
+    first_name = payload_address.recipientName.split(" ")[0];
+    last_name = payload_address.recipientName.split(" ")[1];
   }
-  if (first_name == null || last_name == null) {
-    var first_name = payload.details.firstName;
-    var last_name = payload.details.lastName;
+
+  if (!first_name || !last_name) {
+    first_name = payload.details.firstName;
+    last_name = payload.details.lastName;
   }
 
   return {
     "first_name" : first_name,
     "last_name" : last_name,
-    "address_line_1" : payload.details.shippingAddress.line1,
-    "address_line_2" : payload.details.shippingAddress.line2,
-    "city" : payload.details.shippingAddress.city,
-    "state_code" : payload.details.shippingAddress.state,
-    "zip" : payload.details.shippingAddress.postalCode,
-    "country_code" : payload.details.shippingAddress.countryCode
-  }
+    "address_line_1" : payload_address.line1,
+    "address_line_2" : payload_address.line2,
+    "city" : payload_address.city,
+    "state_code" : payload_address.state,
+    "zip" : payload_address.postalCode,
+    "country_code" : payload_address.countryCode
+  };
 };
-