Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with sprockets-rails 3.0 #618

Closed
jhawthorn opened this issue Dec 22, 2015 · 4 comments
Closed

Compatibility with sprockets-rails 3.0 #618

jhawthorn opened this issue Dec 22, 2015 · 4 comments

Comments

@jhawthorn
Copy link
Contributor

samanmohamadi helpfully points out in #609 that the handlebars_assets issue is fixed in their latest master.

After upgrading to that I have other asset issues:

ActionView::Template::Error:
  Asset was not declared to be precompiled in production.
  Add `Rails.application.config.assets.precompile += %w( logo/solidus_logo.png )` to `config/initializers/assets.rb` and restart your server
# /home/jhawthorn/src/solidus/core/app/helpers/spree/base_helper.rb:67:in `logo'
@jhawthorn jhawthorn changed the title Compatibility with sproclkets-rails 3.0 Compatibility with sprockets-rails 3.0 Dec 22, 2015
@jhawthorn
Copy link
Contributor Author

Optimistically tagging this for 1.2. The sooner we sort this out the better

@jhawthorn jhawthorn added this to the 1.2.0 milestone Dec 23, 2015
@Blackening999
Copy link

I strongly suggest to add a Troubleshooting section to README or consider hotfixes automatically merge to the master.
I've installed raw solidus gem (not bleeding edge pointing to github repo) and it's 1.1.0. The issue still the same.
I've lost 1 hour to find out the solution for that :\

Thank you

@tvdeyen
Copy link
Member

tvdeyen commented Jan 5, 2016

It is very unfortunate that you lost an hour of your precious time.

What should a troubleshooting section in the README cover? Bugs like these happen and can have several causes. We really can't cover every potentially issue.

Debugging is annoying, cumbersome and frustrating, but explaining how to debug a Rails app can't be the purpose of this projects README.

There are lots of great resources out there covering debugging Rails apps.

What Solidus specific debugging advice should we add to the README?

@jhawthorn
Copy link
Contributor Author

@Blackening999 sorry you lost time, but our latest release v1.1.1 does set an explicit dependency on the older sprockets-rails. There's not much more we can do than that to avoid issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants