Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing with other Capybara drivers #1901

Closed
2 tasks done
jhawthorn opened this issue May 9, 2017 · 1 comment
Closed
2 tasks done

Support testing with other Capybara drivers #1901

jhawthorn opened this issue May 9, 2017 · 1 comment
Assignees
Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature

Comments

@jhawthorn
Copy link
Contributor

jhawthorn commented May 9, 2017

Currently our test suite only passes when using phantomjs/poltergeist.

When I originally converted us over (spree/spree#4383) it supported both poltergeist/phantomjs and selenium/firefox, but we've since accidentally added/changed some specs which now break outside of poltergeist.

Since phantomjs's future is uncertain and has the worst es6 support of all browsers we support (including IE11!), we may want to migrate away from it at some point (but hard to say for sure).

Supporting selenium could (maybe) also let us test across our supported browsers.

@jhawthorn jhawthorn added type:enhancement Proposed or newly added feature changelog:solidus_core Changes to the solidus_core gem labels May 9, 2017
@jhawthorn jhawthorn self-assigned this May 9, 2017
@jhawthorn
Copy link
Contributor Author

We are now using selenium + chrome headless for the backend 🎉 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

No branches or pull requests

1 participant