Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with deals_with_adjustments_for_deleted_source #1396

Closed
jordan-brough opened this issue Aug 18, 2016 · 1 comment
Closed

Deal with deals_with_adjustments_for_deleted_source #1396

jordan-brough opened this issue Aug 18, 2016 · 1 comment

Comments

@jordan-brough
Copy link
Contributor

@mtomov pointed out that this:
https://github.com/solidusio/solidus/blob/v1.3.1/core/app/models/concerns/spree/adjustment_source.rb#L7
leaves orders in an incorrect state because it doesn't run order.update! on the affected orders. Should we add that? Should we look for an alternative, like using foreign keys to prevent adjustment sources from be deleted if they are still referenced?
@jordan-brough jordan-brough mentioned this issue Aug 18, 2016
Merged
@jordan-brough
Copy link
Contributor Author

This was taken care of in #2259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordan-brough