Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for subscription checkout to accommodate a more flexible checko… #15

Merged
merged 4 commits into from
Jul 24, 2017

Conversation

joeljackson
Copy link
Contributor

…ut flow.

@mamhoff
Copy link
Contributor

mamhoff commented Jun 9, 2017

Your test for the altered checkout flow alters the checkout flow for all subsequent tests, breaking the build. See how core does spec setup for that.

@joeljackson
Copy link
Contributor Author

@mamhoff Thanks for the tip.

@joeljackson
Copy link
Contributor Author

On solidus < 1.4 I'm finding I'm having to do weird things like "Spree::Order.state_machine.instance_variable_set(:'@action_hook_defined', false)" after redefining the checkout flow to get specs to pass. Any suggestions?

Possible to make the new spec pass for only solidus 1.4+ ?

@qr8r qr8r force-pushed the allow-modified-checkout-flow branch from bcae851 to da1fc88 Compare July 24, 2017 17:40
@qr8r qr8r merged commit 9d7e254 into solidusio:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants